Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ObjectValidator as part of dry run. #4417

Merged
merged 1 commit into from Mar 1, 2023
Merged

Run ObjectValidator as part of dry run. #4417

merged 1 commit into from Mar 1, 2023

Conversation

justinlittman
Copy link
Contributor

closes #4416

Why was this change made? 🤔

Avoid unexpected migration failures.

How was this change tested? 🤨

⚡ ⚠ If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡

QA

@justinlittman
Copy link
Contributor Author

$ RAILS_ENV=production bin/migrate-cocina Migrators::Folio
[DEPRECATION] Committee: please set parameter_overwite_by_rails_rule = false because we'll change default value to "true" in next major version.
dryrun Dro [▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣] (100% (2243/2243), rate: 1014.81/s, mean rate: 592.63/s,  3s total, ETA: 13:52:29)
dryrun Collection [▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣] (100% (486/486), rate: 1047.83/s, mean rate: 1047.83/s,  0s total, ETA: 13:52:30)
dryrun AdminPolicy [▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣▣] (100% (192/192), rate: 4667.01/s, mean rate: 4667.01/s,  0s total, ETA: 13:52:30)
$ grep ERROR migrate-cocina.csv
3807,druid:cy002pz9778,ERROR,"File hierarchy present, but content type is not file"
3806,druid:hz068xz9286,ERROR,"File hierarchy present, but content type is not file"
3809,druid:kv721dz6653,ERROR,"File hierarchy present, but content type is not file"
3808,druid:sm696pt6363,ERROR,"File hierarchy present, but content type is not file"
3805,druid:vr453vw0218,ERROR,"File hierarchy present, but content type is not file"
3927,druid:xj862qt3229,ERROR,"File hierarchy present, but content type is not file"

@justinlittman justinlittman marked this pull request as ready for review March 1, 2023 21:54
@mjgiarlo mjgiarlo merged commit 51dcb69 into main Mar 1, 2023
@mjgiarlo mjgiarlo deleted the t4416-validate branch March 1, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cocina::ValidationError when running migration
2 participants