Merge 766dfa0 into 2fe8adf

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-04-24 12:29:15 -0500 using RuboCop version 0.65.0.
+# on 2019-05-14 11:14:26 -0500 using RuboCop version 0.65.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -41,32 +41,26 @@ Lint/ShadowedArgument:
   Exclude:
     - 'lib/dor/datastreams/embargo_metadata_ds.rb'
 
-# Offense count: 1
-# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
-Lint/UselessAccessModifier:
-  Exclude:
-    - 'lib/dor/services/public_desc_metadata_service.rb'
-
 # Offense count: 1
 # Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:
   Exclude:
     - 'lib/dor/datastreams/identity_metadata_ds.rb'
 
-# Offense count: 53
+# Offense count: 45
 Metrics/AbcSize:
   Max: 106
 
-# Offense count: 10
+# Offense count: 9
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 260
 
-# Offense count: 13
+# Offense count: 12
 Metrics/CyclomaticComplexity:
   Max: 25
 
-# Offense count: 50
+# Offense count: 44
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 52
@@ -85,7 +79,7 @@ Naming/AccessorMethodName:
   Exclude:
     - 'lib/dor/datastreams/rights_metadata_ds.rb'
 
-# Offense count: 6
+# Offense count: 4
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: lowercase, uppercase
 Naming/HeredocDelimiterCase:
@@ -132,14 +126,13 @@ Naming/UncommunicativeMethodParamName:
     - 'lib/dor/datastreams/embargo_metadata_ds.rb'
     - 'lib/dor/datastreams/version_metadata_ds.rb'
 
-# Offense count: 12
+# Offense count: 10
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: snake_case, camelCase
 Naming/VariableName:
   Exclude:
     - 'lib/dor/datastreams/content_metadata_ds.rb'
     - 'lib/dor/datastreams/version_metadata_ds.rb'
-    - 'lib/dor/services/public_desc_metadata_service.rb'
     - 'spec/datastreams/content_metadata_ds_spec.rb'
     - 'spec/indexers/processable_indexer_spec.rb'
 
@@ -161,17 +154,16 @@ RSpec/Be:
   Exclude:
     - 'spec/datastreams/embargo_metadata_spec.rb'
 
-# Offense count: 5
+# Offense count: 4
 RSpec/BeforeAfterAll:
   Exclude:
     - 'spec/spec_helper.rb'
     - 'spec/rails_helper.rb'
     - 'spec/support/**/*.rb'
     - 'spec/services/cleanup_service_spec.rb'
-    - 'spec/services/metadata_service_spec.rb'
     - 'spec/services/suri_service_spec.rb'
 
-# Offense count: 31
+# Offense count: 29
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -183,25 +175,23 @@ RSpec/DescribeClass:
     - 'spec/datastreams/simple_dublin_core_ds_spec.rb'
     - 'spec/services/cleanup_service_filesystem_spec.rb'
 
-# Offense count: 120
+# Offense count: 111
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Enabled: false
 
-# Offense count: 6
+# Offense count: 3
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/datastreams/content_metadata_ds_spec.rb'
-    - 'spec/services/metadata_service_spec.rb'
-    - 'spec/services/public_desc_metadata_service_spec.rb'
     - 'spec/services/status_service_spec.rb'
 
-# Offense count: 44
+# Offense count: 45
 # Configuration parameters: CustomTransform, IgnoreMethods.
 RSpec/FilePath:
   Enabled: false
 
-# Offense count: 377
+# Offense count: 367
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Exclude:
@@ -215,7 +205,6 @@ RSpec/InstanceVariable:
     - 'spec/datastreams/simple_dublin_core_ds_spec.rb'
     - 'spec/models/admin_policy_object_spec.rb'
     - 'spec/services/cleanup_service_spec.rb'
-    - 'spec/services/metadata_service_spec.rb'
     - 'spec/services/search_service_spec.rb'
     - 'spec/services/suri_service_spec.rb'
 
@@ -224,25 +213,20 @@ RSpec/MessageChain:
   Exclude:
     - 'spec/services/suri_service_spec.rb'
 
-# Offense count: 52
+# Offense count: 37
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   Exclude:
     - 'spec/datastreams/content_metadata_ds_spec.rb'
     - 'spec/datastreams/rights_metadata_spec.rb'
     - 'spec/models/item_spec.rb'
-    - 'spec/models/workflow_object_spec.rb'
     - 'spec/services/cleanup_service_spec.rb'
-    - 'spec/services/create_workflow_service_spec.rb'
     - 'spec/services/embargo_service_spec.rb'
-    - 'spec/services/metadata_service_spec.rb'
-    - 'spec/services/public_desc_metadata_service_spec.rb'
-    - 'spec/services/release_tag_service_spec.rb'
     - 'spec/services/status_service_spec.rb'
     - 'spec/services/suri_service_spec.rb'
 
-# Offense count: 166
+# Offense count: 147
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 14
@@ -256,16 +240,16 @@ RSpec/NamedSubject:
     - 'spec/models/collection_spec.rb'
     - 'spec/services/thumbnail_service_spec.rb'
 
-# Offense count: 11
+# Offense count: 5
 RSpec/NestedGroups:
   Max: 4
 
 # Offense count: 2
 RSpec/RepeatedDescription:
   Exclude:
-    - 'spec/services/release_tag_service_spec.rb'
+    - 'spec/release_tags/purl_spec.rb'
 
-# Offense count: 14
+# Offense count: 13
 RSpec/ScatteredLet:
   Exclude:
     - 'spec/indexers/editable_indexer_spec.rb'
@@ -274,29 +258,25 @@ RSpec/ScatteredLet:
     - 'spec/indexers/releaseable_indexer_spec.rb'
     - 'spec/models/item_spec.rb'
     - 'spec/models/workflow_document_spec.rb'
-    - 'spec/services/public_desc_metadata_service_spec.rb'
 
-# Offense count: 10
+# Offense count: 8
 RSpec/ScatteredSetup:
   Exclude:
     - 'spec/datastreams/content_metadata_ds_spec.rb'
     - 'spec/datastreams/rights_metadata_spec.rb'
-    - 'spec/services/public_desc_metadata_service_spec.rb'
     - 'spec/services/search_service_spec.rb'
     - 'spec/services/suri_service_spec.rb'
 
-# Offense count: 16
+# Offense count: 14
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/datastreams/rights_metadata_spec.rb'
     - 'spec/datastreams/version_metadata_spec.rb'
     - 'spec/indexers/identifiable_indexer_spec.rb'
     - 'spec/models/item_spec.rb'
-    - 'spec/models/workflow_object_spec.rb'
     - 'spec/services/cleanup_service_filesystem_spec.rb'
     - 'spec/services/cleanup_service_spec.rb'
-    - 'spec/services/metadata_service_spec.rb'
     - 'spec/services/status_service_spec.rb'
     - 'spec/services/suri_service_spec.rb'
     - 'spec/spec_helper.rb'
@@ -318,13 +298,11 @@ Style/ClassAndModuleChildren:
     - 'lib/dor/utils/ng_tidy.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 11
+# Offense count: 8
 Style/ClassVars:
   Exclude:
     - 'lib/dor-services.rb'
     - 'lib/dor/indexers/identifiable_indexer.rb'
-    - 'lib/dor/models/workflow_object.rb'
-    - 'lib/dor/services/metadata_service.rb'
     - 'lib/dor/services/search_service.rb'
     - 'lib/dor/workflow/document.rb'
 
@@ -341,7 +319,7 @@ Style/ConditionalAssignment:
   Exclude:
     - 'spec/support/foxml_helper.rb'
 
-# Offense count: 53
+# Offense count: 51
 Style/Documentation:
   Enabled: false
 
@@ -358,7 +336,7 @@ Style/MultilineBlockChain:
   Exclude:
     - 'lib/dor/datastreams/workflow_definition_ds.rb'
 
-# Offense count: 29
+# Offense count: 24
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison
@@ -371,14 +349,14 @@ Style/NumericPredicate:
     - 'lib/dor/datastreams/role_metadata_ds.rb'
     - 'lib/dor/datastreams/version_metadata_ds.rb'
     - 'lib/dor/indexers/processable_indexer.rb'
-    - 'lib/dor/services/create_workflow_service.rb'
-    - 'lib/dor/services/release_tag_service.rb'
+    - 'lib/dor/release_tags/identity_metadata.rb'
+    - 'lib/dor/release_tags/purl.rb'
     - 'lib/dor/services/search_service.rb'
     - 'lib/dor/services/tag_service.rb'
     - 'lib/dor/workflow/document.rb'
     - 'lib/dor/workflow/process.rb'
 
-# Offense count: 25
+# Offense count: 22
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -387,34 +365,24 @@ Style/PercentLiteralDelimiters:
     - 'lib/dor/datastreams/rights_metadata_ds.rb'
     - 'lib/dor/indexers/describable_indexer.rb'
     - 'lib/dor/services/cleanup_service.rb'
-    - 'lib/dor/services/metadata_handlers/catalog_handler.rb'
     - 'spec/datastreams/events_ds_spec.rb'
     - 'spec/datastreams/geo_metadata_spec.rb'
     - 'spec/indexers/indexer_spec.rb'
-    - 'spec/services/public_desc_metadata_service_spec.rb'
 
 # Offense count: 3
 # Cop supports --auto-correct.
 Style/PerlBackrefs:
   Exclude:
     - 'lib/dor/datastreams/version_metadata_ds.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/dor/services/public_desc_metadata_service.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: AllowAsExpressionSeparator.
 Style/Semicolon:
   Exclude:
     - 'lib/dor/datastreams/simple_dublin_core_ds.rb'
 
-# Offense count: 18
+# Offense count: 16
 # Cop supports --auto-correct.
 Style/ZeroLengthPredicate:
   Exclude:
@@ -424,6 +392,5 @@ Style/ZeroLengthPredicate:
     - 'lib/dor/datastreams/rights_metadata_ds.rb'
     - 'lib/dor/datastreams/role_metadata_ds.rb'
     - 'lib/dor/datastreams/version_metadata_ds.rb'
-    - 'lib/dor/services/release_tag_service.rb'
     - 'lib/dor/services/search_service.rb'
     - 'lib/dor/workflow/document.rb'

lib/dor-services.rb

@@ -87,6 +87,8 @@ def logger
   end
 
   eager_autoload do
+    autoload :ReleaseTags
+
     # ActiveFedora Classes
     autoload_under 'models' do
       autoload :Abstract
@@ -108,9 +110,10 @@ def logger
     autoload :CollectionService
     autoload :CreativeCommonsLicenseService
     autoload :EmbargoService
+    autoload :IdentityMetadataTagService
     autoload :Ontology
     autoload :OpenDataLicenseService
-    autoload :PurlClient
+    autoload :PurlTagService
     autoload :ReleaseTagService
     autoload :SearchService
     autoload :StatusService

lib/dor/release_tags.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Dor
+  module ReleaseTags
+    extend ActiveSupport::Autoload
+
+    eager_autoload do
+      autoload :PurlClient
+      autoload :Purl
+      autoload :IdentityMetadata
+    end
+  end
+end