Merge 9c71be7 into 70a6677

.rubocop.yml

@@ -1,4 +1,6 @@
 inherit_from: .rubocop_todo.yml
+require: rubocop-rspec
+
 AllCops:
   TargetRubyVersion: 2.3
 

.rubocop_todo.yml

@@ -1,16 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-12-21 13:23:36 -0600 using RuboCop version 0.60.0.
+# on 2019-01-30 10:49:20 -0600 using RuboCop version 0.60.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - 'spec/models/concerns/processable_spec.rb'
-
 # Offense count: 3
 Lint/AmbiguousOperator:
   Exclude:
@@ -70,24 +65,24 @@ Lint/Void:
 
 # Offense count: 83
 Metrics/AbcSize:
-  Max: 122
+  Max: 119
 
-# Offense count: 198
+# Offense count: 203
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 395
+  Max: 394
 
 # Offense count: 14
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 253
 
-# Offense count: 17
+# Offense count: 18
 Metrics/CyclomaticComplexity:
   Max: 25
 
-# Offense count: 79
+# Offense count: 80
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 58
@@ -102,7 +97,7 @@ Metrics/ModuleLength:
 Metrics/ParameterLists:
   Max: 7
 
-# Offense count: 17
+# Offense count: 18
 Metrics/PerceivedComplexity:
   Max: 25
 
@@ -113,7 +108,7 @@ Naming/AccessorMethodName:
     - 'lib/dor/models/concerns/describable.rb'
     - 'lib/dor/models/concerns/governable.rb'
 
-# Offense count: 14
+# Offense count: 15
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: lowercase, uppercase
 Naming/HeredocDelimiterCase:
@@ -161,12 +156,6 @@ Naming/PredicateName:
     - 'lib/dor/models/concerns/contentable.rb'
     - 'lib/dor/models/concerns/identifiable.rb'
 
-# Offense count: 1
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-Naming/UncommunicativeBlockParamName:
-  Exclude:
-    - 'lib/dor/services/public_xml_service.rb'
-
 # Offense count: 11
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db
@@ -179,15 +168,14 @@ Naming/UncommunicativeMethodParamName:
     - 'lib/dor/models/concerns/describable.rb'
     - 'lib/dor/models/concerns/rightsable.rb'
 
-# Offense count: 15
+# Offense count: 14
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: snake_case, camelCase
 Naming/VariableName:
   Exclude:
     - 'lib/dor/datastreams/content_metadata_ds.rb'
     - 'lib/dor/datastreams/version_metadata_ds.rb'
     - 'lib/dor/services/public_desc_metadata_service.rb'
-    - 'lib/dor/services/public_xml_service.rb'
     - 'spec/datastreams/content_metadata_ds_spec.rb'
     - 'spec/datastreams/workflow_ds_spec.rb'
     - 'spec/indexers/processable_indexer_spec.rb'
@@ -200,6 +188,172 @@ Naming/VariableNumber:
     - 'spec/services/cleanup_reset_service_spec.rb'
     - 'spec/services/cleanup_service_filesystem_spec.rb'
 
+# Offense count: 31
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/indexers/indexer_spec.rb'
+    - 'spec/indexers/processable_indexer_spec.rb'
+    - 'spec/models/concerns/describable_spec.rb'
+    - 'spec/models/concerns/embargoable_spec.rb'
+    - 'spec/models/concerns/publishable_spec.rb'
+    - 'spec/models/concerns/versionable_spec.rb'
+    - 'spec/models/workflow_object_spec.rb'
+    - 'spec/services/datastream_builder_spec.rb'
+    - 'spec/services/public_xml_service_spec.rb'
+    - 'spec/services/publish_metadata_service_spec.rb'
+    - 'spec/services/registration_service_spec.rb'
+
+# Offense count: 23
+RSpec/Be:
+  Exclude:
+    - 'spec/datastreams/embargo_metadata_spec.rb'
+    - 'spec/services/file_metadata_merge_service_spec.rb'
+    - 'spec/services/public_xml_service_spec.rb'
+
+# Offense count: 11
+RSpec/BeforeAfterAll:
+  Exclude:
+    - 'spec/spec_helper.rb'
+    - 'spec/rails_helper.rb'
+    - 'spec/support/**/*.rb'
+    - 'spec/models/concerns/assembleable_spec.rb'
+    - 'spec/services/cleanup_reset_service_spec.rb'
+    - 'spec/services/cleanup_service_spec.rb'
+    - 'spec/services/digital_stacks_service_spec.rb'
+    - 'spec/services/metadata_service_spec.rb'
+    - 'spec/services/suri_service_spec.rb'
+    - 'spec/services/technical_metadata_service_spec.rb'
+
+# Offense count: 50
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Enabled: false
+
+# Offense count: 6
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/datastreams/simple_dublin_core_ds_spec.rb'
+    - 'spec/models/concerns/releaseable_no_vcr_spec.rb'
+    - 'spec/models/concerns/releaseable_spec.rb'
+    - 'spec/services/cleanup_service_filesystem_spec.rb'
+    - 'spec/services/digital_stacks_service_spec.rb'
+
+# Offense count: 216
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Enabled: false
+
+# Offense count: 47
+RSpec/ExpectInHook:
+  Exclude:
+    - 'spec/datastreams/content_metadata_ds_spec.rb'
+    - 'spec/datastreams/workflow_ds_spec.rb'
+    - 'spec/models/concerns/assembleable_spec.rb'
+    - 'spec/models/concerns/contentable_spec.rb'
+    - 'spec/models/concerns/publishable_spec.rb'
+    - 'spec/models/concerns/releaseable_spec.rb'
+    - 'spec/services/indexing_service_spec.rb'
+    - 'spec/services/metadata_service_spec.rb'
+    - 'spec/services/public_desc_metadata_service_spec.rb'
+    - 'spec/services/public_xml_service_spec.rb'
+    - 'spec/services/publish_metadata_service_spec.rb'
+    - 'spec/services/registration_service_spec.rb'
+    - 'spec/services/sdr_ingest_service_spec.rb'
+    - 'spec/services/shelving_service_spec.rb'
+    - 'spec/services/status_service_spec.rb'
+
+# Offense count: 69
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Enabled: false
+
+# Offense count: 939
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Enabled: false
+
+# Offense count: 1
+RSpec/MessageChain:
+  Exclude:
+    - 'spec/services/suri_service_spec.rb'
+
+# Offense count: 276
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  Enabled: false
+
+# Offense count: 2
+RSpec/MultipleDescribes:
+  Exclude:
+    - 'spec/models/concerns/releaseable_spec.rb'
+    - 'spec/services/digital_stacks_service_spec.rb'
+
+# Offense count: 345
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 14
+
+# Offense count: 55
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/datastreams/default_object_rights_ds_spec.rb'
+    - 'spec/models/admin_policy_object_spec.rb'
+    - 'spec/models/collection_spec.rb'
+    - 'spec/models/concerns/publishable_spec.rb'
+    - 'spec/services/shelving_service_spec.rb'
+    - 'spec/services/thumbnail_service_spec.rb'
+
+# Offense count: 35
+RSpec/NestedGroups:
+  Max: 5
+
+# Offense count: 22
+RSpec/RepeatedDescription:
+  Exclude:
+    - 'spec/models/concerns/governable_spec.rb'
+    - 'spec/services/abiltiy_spec.rb'
+    - 'spec/services/release_tag_service_spec.rb'
+
+# Offense count: 18
+RSpec/ScatteredLet:
+  Exclude:
+    - 'spec/indexers/describable_indexer_spec.rb'
+    - 'spec/indexers/editable_indexer_spec.rb'
+    - 'spec/indexers/identifiable_indexer_spec.rb'
+    - 'spec/indexers/indexer_spec.rb'
+    - 'spec/indexers/processable_indexer_spec.rb'
+    - 'spec/indexers/releaseable_indexer_spec.rb'
+    - 'spec/models/item_spec.rb'
+    - 'spec/models/workflow_document_spec.rb'
+    - 'spec/services/public_desc_metadata_service_spec.rb'
+    - 'spec/services/public_xml_service_spec.rb'
+    - 'spec/services/shelving_service_spec.rb'
+
+# Offense count: 26
+RSpec/ScatteredSetup:
+  Exclude:
+    - 'spec/datastreams/content_metadata_ds_spec.rb'
+    - 'spec/datastreams/rights_metadata_spec.rb'
+    - 'spec/datastreams/workflow_ds_spec.rb'
+    - 'spec/models/concerns/contentable_spec.rb'
+    - 'spec/models/concerns/describable_spec.rb'
+    - 'spec/models/concerns/editable_spec.rb'
+    - 'spec/models/concerns/governable_spec.rb'
+    - 'spec/models/workflow_object_spec.rb'
+    - 'spec/services/public_desc_metadata_service_spec.rb'
+    - 'spec/services/publish_metadata_service_spec.rb'
+    - 'spec/services/reset_workspace_service_spec.rb'
+    - 'spec/services/search_service_spec.rb'
+    - 'spec/services/suri_service_spec.rb'
+
+# Offense count: 58
+# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
+RSpec/VerifiedDoubles:
+  Enabled: false
+
 # Offense count: 3
 Security/Open:
   Exclude:
@@ -258,7 +412,7 @@ Style/DateTime:
     - 'lib/dor/indexers/processable_indexer.rb'
     - 'lib/dor/services/status_service.rb'
 
-# Offense count: 78
+# Offense count: 79
 Style/Documentation:
   Enabled: false
 

dor-services.gemspec

@@ -55,6 +55,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rdoc'
   s.add_development_dependency 'rspec', '~> 3.1'
   s.add_development_dependency 'rubocop', '~> 0.60.0'
+  s.add_development_dependency 'rubocop-rspec'
   s.add_development_dependency 'simplecov'
   s.add_development_dependency 'vcr'
   s.add_development_dependency 'webmock'

spec/datastreams/administrative_metadata_ds_spec.rb

@@ -5,7 +5,7 @@
 describe Dor::AdministrativeMetadataDS do
   context 'defaults terms' do
     it '#default_workflow_lane gets and sets the attribute defaults/initiateWorkflow/@lane' do
-      ds = Dor::AdministrativeMetadataDS.new
+      ds = described_class.new
       ds.default_workflow_lane = 'slow'
 
       expect(ds.to_xml).to be_equivalent_to(<<-XML
@@ -20,7 +20,7 @@
     end
 
     it '#default_shelving_path gets and sets the attribute defaults/shelving/@path ' do
-      ds = Dor::AdministrativeMetadataDS.new
+      ds = described_class.new
       ds.default_shelving_path = '/hoover'
 
       expect(ds.to_xml).to be_equivalent_to(<<-XML