Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.

Owner cannot be nil #367

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Owner cannot be nil #367

merged 1 commit into from
Nov 15, 2018

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jul 17, 2018

Otherwise ready? or blocked? would issue a Nil pointer exception

This addresses one of the most prevalent errors in dor_indexing_app

Otherwise ready? or blocked? would issue a Nil pointer exception
@coveralls
Copy link

coveralls commented Jul 17, 2018

Coverage Status

Coverage remained the same at 90.668% when pulling 3b8a84f on owner-not-nil into 39eb601 on master.

Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful change because it allows us to better diagnose the underlying error which is occurring thousands of times.

@mjgiarlo mjgiarlo merged commit 71b77a3 into master Nov 15, 2018
@mjgiarlo mjgiarlo deleted the owner-not-nil branch November 15, 2018 19:56
jcoyne added a commit to sul-dlss-deprecated/dor_indexing_app that referenced this pull request Nov 15, 2018
This should prevent a nil pointer error #138
which is guarded against in sul-dlss-deprecated/dor-services#367
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants