Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.

ShelvingService#shelve must be public #439

Merged
merged 1 commit into from Dec 21, 2018
Merged

ShelvingService#shelve must be public #439

merged 1 commit into from Dec 21, 2018

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Dec 21, 2018 •
edited

Othewise ShelvingService.shelve gets an error as it tries to call a private method

@jcoyne
ShelvingService#shelve must be public
cbada00 
Othwise ShelvingService.shelve gets an error as it tries to call a private method
justinlittman
justinlittman approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@justinlittman justinlittman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve pending green Travis.

@coveralls
Copy link

coveralls commented Dec 21, 2018 •
edited

Coverage Status

Coverage increased (+0.04%) to 91.708% when pulling cbada00 on shelve_public into b8010d2 on master.

@justinlittman justinlittman merged commit 602e0a8 into master Dec 21, 2018
@justinlittman justinlittman deleted the shelve_public branch December 21, 2018 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinlittman justinlittman justinlittman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcoyne @coveralls @justinlittman