Merge 47774dd into 993342f

.rubocop_todo.yml

@@ -1,292 +1,19 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-01-10 11:50:38 -0600 using RuboCop version 0.58.2.
+# on 2019-04-08 11:23:59 -0500 using RuboCop version 0.58.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 11
+# Offense count: 12
 # Cop supports --auto-correct.
 # Configuration parameters: Include, TreatCommentsAsGroupSeparators.
 # Include: **/*.gemfile, **/Gemfile, **/gems.rb
 Bundler/OrderedGems:
   Exclude:
     - 'Gemfile'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_parameter, with_fixed_indentation
-Layout/AlignParameters:
-  Exclude:
-    - 'config/initializers/mime_types.rb'
-    - 'spec/features/item_edit_spec.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith.
-# SupportedStylesAlignWith: either, start_of_block, start_of_line
-Layout/BlockAlignment:
-  Exclude:
-    - 'app/controllers/hydrus_items_controller.rb'
-    - 'spec/models/hydrus/generic_object_spec.rb'
-    - 'spec/models/hydrus/related_item_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
-# SupportedStyles: case, end
-Layout/CaseIndentation:
-  Exclude:
-    - 'lib/validators/uri_validator.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-Layout/ClosingHeredocIndentation:
-  Exclude:
-    - 'app/helpers/application_helper.rb'
-    - 'spec/models/hydrus/related_item_spec.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-Layout/ClosingParenthesisIndentation:
-  Exclude:
-    - 'app/controllers/hydrus_items_controller.rb'
-    - 'app/models/hydrus/collection.rb'
-    - 'app/models/hydrus/desc_metadata_ds.rb'
-    - 'app/models/solr_document.rb'
-    - 'config/rsolr_certificate.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-Layout/CommentIndentation:
-  Exclude:
-    - 'app/controllers/catalog_controller.rb'
-    - 'app/models/hydrus/item.rb'
-    - 'app/models/user_role.rb'
-    - 'config/rsolr_no_certificate.rb'
-    - 'spec/support/rubydora_transactions_monkeypatch.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
-# SupportedStylesAlignWith: start_of_line, def
-Layout/DefEndAlignment:
-  Exclude:
-    - 'config/rsolr_no_certificate.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: leading, trailing
-Layout/DotPosition:
-  Exclude:
-    - 'app/controllers/hydrus_collections_controller.rb'
-    - 'app/models/hydrus/item.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/ElseAlignment:
-  Exclude:
-    - 'config/rsolr_no_certificate.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterMagicComment:
-  Exclude:
-    - 'app/controllers/catalog_controller.rb'
-    - 'app/models/solr_document.rb'
-    - 'db/migrate/20120502214252_create_searches.rb'
-    - 'db/migrate/20120502214253_create_bookmarks.rb'
-    - 'db/migrate/20120502214254_remove_editable_fields_from_bookmarks.rb'
-    - 'db/migrate/20120502214255_add_user_types_to_bookmarks_searches.rb'
-
-# Offense count: 12
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines.
-Layout/EmptyLineBetweenDefs:
-  Exclude:
-    - 'app/models/hydrus/collection.rb'
-    - 'app/models/hydrus/generic_object.rb'
-    - 'app/models/hydrus/item.rb'
-    - 'app/models/hydrus/responsible.rb'
-    - 'app/models/hydrus/solr_queryable.rb'
-    - 'config/initializers/action_dispatch_http_upload_monkey_patch.rb'
-    - 'spec/models/hydrus/generic_object_spec.rb'
-    - 'spec/models/hydrus/validatable_spec.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/EmptyLinesAroundAccessModifier:
-  Exclude:
-    - 'app/controllers/hydrus_collections_controller.rb'
-    - 'app/controllers/hydrus_solr_controller.rb'
-
-# Offense count: 15
-# Cop supports --auto-correct.
-Layout/EmptyLinesAroundMethodBody:
-  Exclude:
-    - 'app/controllers/catalog_controller.rb'
-    - 'app/controllers/hydrus_collections_controller.rb'
-    - 'app/controllers/hydrus_items_controller.rb'
-    - 'app/helpers/application_helper.rb'
-    - 'app/models/hydrus/collection.rb'
-    - 'app/models/hydrus/solr_queryable.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Layout/EndAlignment:
-  Exclude:
-    - 'config/rsolr_no_certificate.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Exclude:
-    - 'app/models/hydrus/generic_object_stuff.rb'
-    - 'app/models/hydrus/item.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
-Layout/FirstParameterIndentation:
-  Exclude:
-    - 'app/models/hydrus/collection.rb'
-    - 'app/models/solr_document.rb'
-    - 'config/rsolr_certificate.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_brackets
-Layout/IndentArray:
-  EnforcedStyle: consistent
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_braces
-Layout/IndentHash:
-  Exclude:
-    - 'devel/dashboard_experiment.rb'
-    - 'spec/features/collection_create_spec.rb'
-    - 'spec/models/hydrus/collection_spec.rb'
-
-# Offense count: 25
-# Cop supports --auto-correct.
-Layout/LeadingCommentSpace:
-  Exclude:
-    - 'app/controllers/catalog_controller.rb'
-    - 'app/models/hydrus/collection.rb'
-    - 'app/models/hydrus/generic_object.rb'
-    - 'app/models/hydrus/item.rb'
-    - 'app/models/hydrus/responsible.rb'
-    - 'app/models/hydrus/solr_queryable.rb'
-    - 'app/models/user_role.rb'
-    - 'config/initializers/devise.rb'
-    - 'config/rsolr_no_certificate.rb'
-    - 'spec/features/item_edit_spec.rb'
-    - 'spec/models/hydrus/solr_queryable_spec.rb'
-    - 'spec/support/rubydora_transactions_monkeypatch.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Layout/MultilineBlockLayout:
-  Exclude:
-    - 'spec/models/hydrus/related_item_spec.rb'
-
-# Offense count: 18
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineMethodCallBraceLayout:
-  Exclude:
-    - 'app/models/hydrus/admin_policy_object.rb'
-    - 'app/models/hydrus/contentable.rb'
-    - 'app/models/hydrus/generic_object_stuff.rb'
-    - 'app/models/hydrus/item.rb'
-    - 'spec/controllers/hydrus_collections_controller_spec.rb'
-    - 'spec/controllers/hydrus_items_controller_spec.rb'
-    - 'spec/features/item_edit_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented, indented_relative_to_receiver
-Layout/MultilineMethodCallIndentation:
-  Exclude:
-    - 'app/helpers/application_helper.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented
-Layout/MultilineOperationIndentation:
-  Exclude:
-    - 'app/models/hydrus/cant.rb'
-
-# Offense count: 19
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
-Layout/SpaceAroundEqualsInParameterDefault:
-  Exclude:
-    - 'app/helpers/hydrus_form_helper.rb'
-    - 'app/mailers/hydrus_mailer.rb'
-    - 'app/models/hydrus/collection.rb'
-    - 'app/models/hydrus/generic_object.rb'
-    - 'app/models/hydrus/item.rb'
-
-# Offense count: 11
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Layout/SpaceAroundOperators:
-  Exclude:
-    - 'app/models/hydrus/authorizable.rb'
-    - 'app/models/hydrus/item.rb'
-    - 'app/models/hydrus/object_file.rb'
-    - 'config/rsolr_no_certificate.rb'
-    - 'spec/support/helpers.rb'
-
-# Offense count: 9
-# Cop supports --auto-correct.
-Layout/SpaceBeforeComma:
-  Exclude:
-    - 'app/models/hydrus/generic_object.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IndentationWidth.
-Layout/Tab:
-  Exclude:
-    - 'app/models/hydrus/generic_object.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: final_newline, final_blank_line
-Layout/TrailingBlankLines:
-  Exclude:
-    - 'app/controllers/events_controller.rb'
-    - 'app/models/hydrus/eventable.rb'
-    - 'app/models/hydrus/licenseable.rb'
-    - 'app/models/hydrus/user_workflowable.rb'
-    - 'config/boot.rb'
-    - 'config/rsolr_certificate.rb'
-    - 'lib/validators/uri_validator.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'spec/controllers/events_controller_spec.rb'
-
 # Offense count: 4
 Lint/AmbiguousOperator:
   Exclude:
@@ -409,7 +136,7 @@ Metrics/BlockLength:
 # Offense count: 9
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 543
+  Max: 544
 
 # Offense count: 13
 Metrics/CyclomaticComplexity:
@@ -564,7 +291,7 @@ Performance/StringReplacement:
     - 'app/models/hydrus/responsible.rb'
     - 'lib/tasks/fixtures.rake'
 
-# Offense count: 36
+# Offense count: 37
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: percent_q, bare_percent
@@ -580,7 +307,7 @@ Style/BarePercentLiterals:
     - 'spec/models/hydrus/role_metadata_ds_spec.rb'
     - 'spec/models/hydrus/solr_queryable_spec.rb'
 
-# Offense count: 68
+# Offense count: 69
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining
@@ -798,7 +525,7 @@ Style/LineEndConcatenation:
   Exclude:
     - 'spec/models/hydrus/item_spec.rb'
 
-# Offense count: 89
+# Offense count: 84
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 Style/MethodCallWithoutArgsParentheses:
@@ -906,7 +633,7 @@ Style/ParenthesesAroundCondition:
     - 'app/models/hydrus/item.rb'
     - 'app/models/hydrus/object_file.rb'
 
-# Offense count: 127
+# Offense count: 128
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -1023,7 +750,7 @@ Style/StringLiteralsInInterpolation:
   Exclude:
     - 'app/helpers/hydrus_form_helper.rb'
 
-# Offense count: 62
+# Offense count: 63
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
@@ -1058,14 +785,14 @@ Style/TrailingCommaInArguments:
     - 'spec/features/item_create_spec.rb'
     - 'spec/features/item_edit_spec.rb'
 
-# Offense count: 61
+# Offense count: 60
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
 Style/TrailingCommaInArrayLiteral:
   Enabled: false
 
-# Offense count: 87
+# Offense count: 85
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
@@ -1098,7 +825,7 @@ Style/UnneededInterpolation:
   Exclude:
     - 'app/models/hydrus/item.rb'
 
-# Offense count: 21
+# Offense count: 22
 # Cop supports --auto-correct.
 Style/UnneededPercentQ:
   Exclude:
@@ -1128,7 +855,7 @@ Style/WordArray:
 Style/ZeroLengthPredicate:
   Enabled: false
 
-# Offense count: 929
+# Offense count: 944
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength: