OCLC Processing of MARC Records #893
Conversation
jermnelson
force-pushed
the
t871-oclc-marc
branch
4 times, most recently
from
59d4bc7
to
da47c85
Compare
jermnelson
force-pushed
the
t871-oclc-marc
branch
from
da47c85
to
2dfde01
Compare
| transformer = Transformer() | ||
| for marc_file in marc_file_list: | ||
| for marc_file in ast.literal_eval(marc_file_list): |
There was a problem hiding this comment.
When running the DAG on development, the marc_file_list was coming in as string instead of as a list, this method call converts the string into a list.
There was a problem hiding this comment.
I just wanted to see what this looked like and what it did...I assume something like this?
>>> file_list = "['path/to/file/1.txt', 'path/to/file/two.csv', 'path/to/file/3.txt']"
>>> type(file_list)
<class 'str'>
>>> type(ast.literal_eval(file_list))
<class 'list'>
>>> ast.dump(ast.parse(file_list))
"Module(body=[Expr(value=List(elts=[Constant(value='path/to/file/1.txt'), Constant(value='path/to/file/two.csv'), Constant(value='path/to/fil3/3.txt')], ctx=Load()))], type_ignores=[])"
pretty cool!
https://docs.python.org/3/library/ast.html#ast.List
| codes.append(oclc_code) | ||
| return codes | ||
|
|
||
| def divide(self, marc_file): |
There was a problem hiding this comment.
Does this need a None return type?
There was a problem hiding this comment.
Good catch! Updating.
| transformer = Transformer() | ||
| for marc_file in marc_file_list: | ||
| for marc_file in ast.literal_eval(marc_file_list): |
There was a problem hiding this comment.
I just wanted to see what this looked like and what it did...I assume something like this?
>>> file_list = "['path/to/file/1.txt', 'path/to/file/two.csv', 'path/to/file/3.txt']"
>>> type(file_list)
<class 'str'>
>>> type(ast.literal_eval(file_list))
<class 'list'>
>>> ast.dump(ast.parse(file_list))
"Module(body=[Expr(value=List(elts=[Constant(value='path/to/file/1.txt'), Constant(value='path/to/file/two.csv'), Constant(value='path/to/fil3/3.txt')], ctx=Load()))], type_ignores=[])"
pretty cool!
https://docs.python.org/3/library/ast.html#ast.List
| transformer = OCLCTransformer() | ||
| for marc_file in ast.literal_eval(marc_file_list): | ||
| transformer.divide(marc_file) | ||
| transformer.save() |
There was a problem hiding this comment.
Can we name this variable oclc_transformer instead?
jermnelson
force-pushed
the
t871-oclc-marc
branch
from
0a76a85
to
d6b8b3a
Compare
Fixes #871
TODO: