Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate isbn list for gobi #937

Merged
merged 6 commits into from
May 13, 2024
Merged

Generate isbn list for gobi #937

merged 6 commits into from
May 13, 2024

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented Apr 19, 2024 •
edited

Creates class for saving gobi isbn lists.
Fixes #872
Uses mock client from transformer for tests

@jgreben jgreben changed the title 872 gobi lists Generate isbn list for gobi Apr 19, 2024
@jgreben jgreben force-pushed the 872-gobi-lists branch 4 times, most recently from 2f3b35c to 077cb0a Compare May 2, 2024 01:54
@jgreben jgreben marked this pull request as ready for review May 2, 2024 15:28
@jgreben jgreben mentioned this pull request May 2, 2024
Closed
jermnelson
jermnelson requested changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@jermnelson jermnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for retrieving MARC fields to handle edge cases where multiple fields for the same tag exist or missing fields.

libsys_airflow/plugins/data_exports/marc/gobi.py Outdated Show resolved Hide resolved
@jgreben jgreben marked this pull request as draft May 8, 2024 22:40
@jgreben jgreben force-pushed the 872-gobi-lists branch 2 times, most recently from 11a7533 to cb5d4f8 Compare May 9, 2024 22:32
@jgreben jgreben marked this pull request as ready for review May 9, 2024 22:32
@jgreben jgreben requested a review from jermnelson May 9, 2024 22:32
@jgreben jgreben marked this pull request as draft May 10, 2024 16:18
@jgreben jgreben marked this pull request as ready for review May 10, 2024 20:42
@jgreben
Copy link
Contributor Author

jgreben commented May 13, 2024

@jermnelson can you take another look at this PR. I made changes that hopefully address the problem of repeatable MARC fields.

jermnelson
jermnelson requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@jermnelson jermnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested change so we check all of the isbns.

libsys_airflow/plugins/data_exports/marc/gobi.py Outdated Show resolved Hide resolved
@jgreben jgreben requested a review from jermnelson May 13, 2024 22:05
@jermnelson jermnelson merged commit f02ac4b into main May 13, 2024
4 checks passed
@jermnelson jermnelson deleted the 872-gobi-lists branch May 13, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jermnelson jermnelson jermnelson approved these changes

@shelleydoljack shelleydoljack Awaiting requested review from shelleydoljack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add function(s) for creating Gobi lists for Data Export
2 participants
@jgreben @jermnelson