Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set leader position 5 to "d" for records in deletes list #975

Merged
merged 6 commits into from
May 9, 2024
Merged

Set leader position 5 to "d" for records in deletes list #975

merged 6 commits into from
May 9, 2024

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented May 9, 2024 •
edited

Fixes #969

@jgreben jgreben linked an issue May 9, 2024 that may be closed by this pull request
Deletes for POD #969
Closed
jermnelson
jermnelson approved these changes May 9, 2024
View reviewed changes
libsys_airflow/plugins/data_exports/marc/transforms.py

for i, record in enumerate(marc_records):
try:
record.leader = pymarc.leader.Leader(record.leader)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If/when this upstream PR 209 is merged, should be able to remove this line (but it won't hurt anything if it still remains)

@jermnelson jermnelson merged commit cbbd96b into main May 9, 2024
4 checks passed
@jermnelson jermnelson deleted the 969-deletes-for-pod branch May 9, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jermnelson jermnelson jermnelson approved these changes

@shelleydoljack shelleydoljack Awaiting requested review from shelleydoljack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deletes for POD
2 participants
@jgreben @jermnelson