Deduplicate uuids fetched from sql and handle absent uuids in 999 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jermnelson
requested changes
May 14, 2024
jgreben
force-pushed
the
jgreben-patch-999s
branch
from
0f4d090
to
c6e1454
Compare
shelleydoljack
approved these changes
May 15, 2024
jermnelson
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that some records already had 999 fields without subfield I, and the code was just looking for the first 999 field and silently skipping the block when no subfield I was present. This change checks all of the 999 fields for uuids and raises an excepted exception if none are found.
Also de-duplicate any uuids fetched via SQL for updates and deletes.