Merge 2e1d777 into 68d7996

README.md

@@ -48,6 +48,14 @@ RAILS_ENV=test rake db:seed
 
 NOTE: Travis uses `db:test:prepare` rather than `db:migrate`
 
+Also make sure the necessary `tmp` file directories are present (this is to mock the `/symphony` mount on the libsys-webforms servers)
+```
+mkdir -p tmp/Dataload/BookplateMerge/Batches/Queue
+mkdir -p tmp/Dataload/EndowRpt
+mkdir -p tmp/Dataload/ILLiadUserExport
+mkdir -p tmp/Dataload/UserloadRerun
+```
+
 ### Rake, etc.
 The test suite (with RuboCop style enforcement) will be run with the default rake task (also run on travis)
 

app/views/sal3_batch_requests_batches/new.html.erb

@@ -87,7 +87,7 @@
     <div class='form-group row'>
       <%= f.label :batch_needbydate, "All items delivered by:*", class: 'col-sm-2 form-control-label' %>
       <div class='col-sm-10'>
-        <%= f.date_field 'batch_needbydate', id: 'dp2', class: 'form-control', value: "#{6.months.from_now.strftime('%Y-%m-%d')}" %>
+        <%= f.date_field 'batch_needbydate', id: 'dp2', class: 'form-control' %>
       </div>
     </div>
     <div class='form-group row'>

db/migrate/20160419171346_create_authorized_users.rb

@@ -1,4 +1,4 @@
-class CreateAuthorizedUsers < ActiveRecord::Migration
+class CreateAuthorizedUsers < ActiveRecord::Migration[5.0]
   def change
     create_table :authorized_users do |t|
       t.string :user_id

db/migrate/20160419173515_rename_authorized_users_to_authorized_user.rb

@@ -1,4 +1,4 @@
-class RenameAuthorizedUsersToAuthorizedUser < ActiveRecord::Migration
+class RenameAuthorizedUsersToAuthorizedUser < ActiveRecord::Migration[5.0]
   def change
     rename_table :authorized_users, :authorized_user
   end

db/migrate/20160421213610_create_uni_updates_errors.rb

@@ -1,4 +1,4 @@
-class CreateUniUpdatesErrors < ActiveRecord::Migration
+class CreateUniUpdatesErrors < ActiveRecord::Migration[5.0]
   def change
     create_table :uni_updates_errors do |t|
       t.string :run

db/migrate/20160502230655_create_uni_updates_batch.rb

@@ -1,4 +1,4 @@
-class CreateUniUpdatesBatch < ActiveRecord::Migration
+class CreateUniUpdatesBatch < ActiveRecord::Migration[5.0]
   def change
     create_table :uni_updates_batch, :primary_key => :batch_id do |t|
       t.datetime :batch_date

db/migrate/20160504234929_create_uni_updates.rb

@@ -1,4 +1,4 @@
-class CreateUniUpdates < ActiveRecord::Migration
+class CreateUniUpdates < ActiveRecord::Migration[5.0]
   def change
     create_table :uni_updates do |t|
       t.integer :batch_id

db/migrate/20160509190330_create_unicorn_policies.rb

@@ -1,4 +1,4 @@
-class CreateUnicornPolicies < ActiveRecord::Migration
+class CreateUnicornPolicies < ActiveRecord::Migration[5.0]
   def change
     create_table :unicorn_policies do |t|
       t.string :type

db/migrate/20160613215612_sal3_batch_requests_batch.rb

@@ -1,4 +1,4 @@
-class Sal3BatchRequestsBatch < ActiveRecord::Migration
+class Sal3BatchRequestsBatch < ActiveRecord::Migration[5.0]
   def change
     create_table :sal3_batch_requests_batch, primary_key: "batch_id" do |t|
       t.string    :batch_name

db/migrate/20160613215951_sal3_batch_requests_bcs.rb

@@ -1,4 +1,4 @@
-class Sal3BatchRequestsBcs < ActiveRecord::Migration
+class Sal3BatchRequestsBcs < ActiveRecord::Migration[5.0]
   def change
     create_table :sal3_batch_requests_bcs do |t|
       t.integer   :batch_id

db/migrate/20160616230554_encumbrance_report.rb

@@ -1,4 +1,4 @@
-class EncumbranceReport < ActiveRecord::Migration
+class EncumbranceReport < ActiveRecord::Migration[5.0]
   def change
     create_table :encumbrance_rpts do |t|
       t.datetime  :date_request

db/migrate/20160617212136_expenditures_funds.rb

@@ -1,4 +1,4 @@
-class ExpendituresFunds < ActiveRecord::Migration
+class ExpendituresFunds < ActiveRecord::Migration[5.0]
   def change
     create_table  :expenditures_funds do |t|
       t.string    :fund_id, array: true

db/migrate/20160622001510_create_uni_libs_locs.rb

@@ -1,4 +1,4 @@
-class CreateUniLibsLocs < ActiveRecord::Migration
+class CreateUniLibsLocs < ActiveRecord::Migration[5.0]
   def change
     create_table :uni_libs_locs do |t|
       t.string :library

db/migrate/20160622222820_expenditure_report.rb

@@ -1,4 +1,4 @@
-class ExpenditureReport < ActiveRecord::Migration
+class ExpenditureReport < ActiveRecord::Migration[5.0]
   def change
     create_table :expenditures_log do |t|
       t.datetime  :date_request

db/migrate/20160627210324_create_shelf_sel_search.rb

@@ -1,4 +1,4 @@
-class CreateShelfSelSearch < ActiveRecord::Migration
+class CreateShelfSelSearch < ActiveRecord::Migration[5.0]
   def change
     create_table :shelf_sel_searches do |t|
       t.string :user_name

db/migrate/20160629173630_create_circulation_statistics_report_format.rb

@@ -1,4 +1,4 @@
-class CreateCirculationStatisticsReportFormat < ActiveRecord::Migration
+class CreateCirculationStatisticsReportFormat < ActiveRecord::Migration[5.0]
   def change
     create_table :circ_stats_rpt_fmts do |t|
       t.string :format

db/migrate/20160629183417_create_shelf_selection_item_type.rb

@@ -1,4 +1,4 @@
-class CreateShelfSelectionItemType < ActiveRecord::Migration
+class CreateShelfSelectionItemType < ActiveRecord::Migration[5.0]
   def change
     create_table :shelf_sel_item_types do |t|
       t.string :item_type

db/migrate/20160629201416_create_shelf_sel_item_cat1.rb

@@ -1,4 +1,4 @@
-class CreateShelfSelItemCat1 < ActiveRecord::Migration
+class CreateShelfSelItemCat1 < ActiveRecord::Migration[5.0]
   def change
     create_table :shelf_sel_item_cat1s do |t|
       t.string :item_category1

db/migrate/20160701214235_expenditures_paydates.rb

@@ -1,4 +1,4 @@
-class ExpendituresPaydates < ActiveRecord::Migration
+class ExpendituresPaydates < ActiveRecord::Migration[5.0]
   def change
     create_table :expenditures_paydates do |t|
       t.datetime  :pay_date

db/migrate/20160708184849_expenditures_with_circ_stats_report.rb

@@ -1,4 +1,4 @@
-class ExpendituresWithCircStatsReport < ActiveRecord::Migration
+class ExpendituresWithCircStatsReport < ActiveRecord::Migration[5.0]
   def change
     create_table :expenditures_circ_log do |t|
       t.datetime  :date_request

db/migrate/20160711225050_expenditures.rb

@@ -1,4 +1,4 @@
-class Expenditures < ActiveRecord::Migration
+class Expenditures < ActiveRecord::Migration[5.0]
   def change
     create_table :expenditures do |t|
       t.datetime  :row_date

db/migrate/20160725235009_create_circulation_statistics_report_logs.rb

@@ -1,4 +1,4 @@
-class CreateCirculationStatisticsReportLogs < ActiveRecord::Migration
+class CreateCirculationStatisticsReportLogs < ActiveRecord::Migration[5.0]
   def change
     create_table :circ_stats_rpt_log do |t|
       t.datetime :date_request

db/migrate/20160923032722_create_expenditures_fy_dates.rb

@@ -1,4 +1,4 @@
-class CreateExpendituresFyDates < ActiveRecord::Migration
+class CreateExpendituresFyDates < ActiveRecord::Migration[5.0]
   def change
     create_table :expenditures_fy_dates do |t|
       t.integer :fy

db/migrate/20161114234536_add_sal3_breq_edit_to_authorized_user.rb

@@ -1,4 +1,4 @@
-class AddSal3BreqEditToAuthorizedUser < ActiveRecord::Migration
+class AddSal3BreqEditToAuthorizedUser < ActiveRecord::Migration[5.0]
   def change
     add_column :authorized_user, :sal3_breq_edit, :string
   end

db/migrate/20161215190807_change_uni_updates_load_date.rb

@@ -1,4 +1,4 @@
-class ChangeUniUpdatesLoadDate < ActiveRecord::Migration
+class ChangeUniUpdatesLoadDate < ActiveRecord::Migration[5.0]
   def change
     change_column :uni_updates, :load_date, :date
   end

db/migrate/20170104223522_add_userload_rerun_to_authorized_user.rb

@@ -1,4 +1,4 @@
-class AddUserloadRerunToAuthorizedUser < ActiveRecord::Migration
+class AddUserloadRerunToAuthorizedUser < ActiveRecord::Migration[5.0]
   def change
     add_column :authorized_user, :userload_rerun, :string
   end

db/migrate/20170516214706_add_accession_number_to_authorized_user.rb

@@ -1,4 +1,4 @@
-class AddAccessionNumberToAuthorizedUser < ActiveRecord::Migration
+class AddAccessionNumberToAuthorizedUser < ActiveRecord::Migration[5.0]
   def change
     add_column :authorized_user, :accession_number, :string
   end

db/migrate/20171219222043_create_accession_numbers.rb

@@ -1,4 +1,4 @@
-class CreateAccessionNumbers < ActiveRecord::Migration
+class CreateAccessionNumbers < ActiveRecord::Migration[5.0]
   def change
     create_table :catnums do |t|
       t.string :item_type

db/migrate/20180301230700_add_bc_file_obj_to_sal3_batch_requests_batch.rb

@@ -1,4 +1,4 @@
-class AddBcFileObjToSal3BatchRequestsBatch < ActiveRecord::Migration
+class AddBcFileObjToSal3BatchRequestsBatch < ActiveRecord::Migration[5.0]
   def change
     add_column :sal3_batch_requests_batch, :bc_file_obj, :string
   end

db/migrate/20180302174149_create_digital_bookplates_batches.rb

@@ -1,4 +1,4 @@
-class CreateDigitalBookplatesBatches < ActiveRecord::Migration
+class CreateDigitalBookplatesBatches < ActiveRecord::Migration[5.0]
   def change
     create_table :digital_bookplates_batches, primary_key: 'batch_id' do |t|
       t.string :ckey_file

db/migrate/20180302192912_add_digital_bookplates_to_authorized_user.rb

@@ -1,4 +1,4 @@
-class AddDigitalBookplatesToAuthorizedUser < ActiveRecord::Migration
+class AddDigitalBookplatesToAuthorizedUser < ActiveRecord::Migration[5.0]
   def change
     add_column :authorized_user, :digital_bookplates, :string
   end

db/migrate/20180521184955_add_pull_date_to_sal3_batch_requests_bcs.rb

@@ -1,4 +1,4 @@
-class AddPullDateToSal3BatchRequestsBcs < ActiveRecord::Migration
+class AddPullDateToSal3BatchRequestsBcs < ActiveRecord::Migration[5.0]
   def change
     add_column :sal3_batch_requests_bcs, :pull_date, :datetime
   end

db/migrate/20180621234315_add_edi_inv_manage_to_authorized_user.rb

@@ -1,4 +1,4 @@
-class AddEdiInvManageToAuthorizedUser < ActiveRecord::Migration
+class AddEdiInvManageToAuthorizedUser < ActiveRecord::Migration[5.0]
   def change
     add_column :authorized_user, :edi_inv_manage, :string
   end

db/migrate/20180621234547_add_edi_inv_view_to_authorized_user.rb

@@ -1,4 +1,4 @@
-class AddEdiInvViewToAuthorizedUser < ActiveRecord::Migration
+class AddEdiInvViewToAuthorizedUser < ActiveRecord::Migration[5.0]
   def change
     add_column :authorized_user, :edi_inv_view, :string
   end

db/migrate/20180622233540_create_edi_invoice.rb

@@ -1,4 +1,4 @@
-class CreateEdiInvoice < ActiveRecord::Migration
+class CreateEdiInvoice < ActiveRecord::Migration[5.0]
   def change
     create_table :edi_invoice do |t|
       t.string :edi_doc_num

db/migrate/20180628180104_create_edi_error_report.rb

@@ -1,4 +1,4 @@
-class CreateEdiErrorReport < ActiveRecord::Migration
+class CreateEdiErrorReport < ActiveRecord::Migration[5.0]
   def change
     create_table :edi_error_report do |t|
       t.datetime :run

db/migrate/20180710170358_create_edi_inv_line.rb

@@ -1,4 +1,4 @@
-class CreateEdiInvLine < ActiveRecord::Migration
+class CreateEdiInvLine < ActiveRecord::Migration[5.0]
   def change
     create_table :edi_inv_line, primary_key: 'tbl_row_num' do |t|
       t.string :edi_vend_id

db/migrate/20180712235601_add_todo_to_edi_inv_line.rb

@@ -1,4 +1,4 @@
-class AddTodoToEdiInvLine < ActiveRecord::Migration
+class AddTodoToEdiInvLine < ActiveRecord::Migration[5.0]
   def change
     add_column :edi_inv_line, :todo, :string
   end

db/migrate/20180716234659_create_edi_lin.rb

@@ -1,4 +1,4 @@
-class CreateEdiLin < ActiveRecord::Migration
+class CreateEdiLin < ActiveRecord::Migration[5.0]
   def change
     create_table :edi_lin do |t|
       t.string :doc_num

db/migrate/20180718164936_create_edi_sumrz_bib.rb

@@ -1,4 +1,4 @@
-class CreateEdiSumrzBib < ActiveRecord::Migration
+class CreateEdiSumrzBib < ActiveRecord::Migration[5.0]
   def change
     create_table :edi_sumrz_bib do |t|
       t.string :vend_code

db/migrate/20180725205541_create_edi_inv_piece.rb

@@ -1,4 +1,4 @@
-class CreateEdiInvPiece < ActiveRecord::Migration
+class CreateEdiInvPiece < ActiveRecord::Migration[5.0]
   def change
     create_table :edi_inv_piece do |t|
       t.string :edi_vend_id

db/migrate/20180725220246_add_columns_to_edi_invoice.rb

@@ -1,4 +1,4 @@
-class AddColumnsToEdiInvoice < ActiveRecord::Migration
+class AddColumnsToEdiInvoice < ActiveRecord::Migration[5.0]
   def change
     add_column :edi_invoice, :edi_msg_id, :string
     add_column :edi_invoice, :edi_msg_typ, :string

db/migrate/20180727193130_add_columns_to_edi_lin.rb

@@ -1,4 +1,4 @@
-class AddColumnsToEdiLin < ActiveRecord::Migration
+class AddColumnsToEdiLin < ActiveRecord::Migration[5.0]
   def change
     add_column :edi_lin, :barcode_num, :integer, limit: 6
   end

db/migrate/20180808230015_remove_bc_file_ob_from_sal3_batch_request_batch.rb

@@ -1,4 +1,4 @@
-class RemoveBcFileObFromSal3BatchRequestBatch < ActiveRecord::Migration
+class RemoveBcFileObFromSal3BatchRequestBatch < ActiveRecord::Migration[5.0]
   def change
     remove_column :sal3_batch_requests_batch, :bc_file_obj, :string
   end

db/migrate/20180822231624_create_packages.rb

@@ -1,4 +1,4 @@
-class CreatePackages < ActiveRecord::Migration
+class CreatePackages < ActiveRecord::Migration[5.0]
   def change
     create_table :vnd_packages, :primary_key => :record_id do |t|
       t.string :package_id

db/migrate/20180822235605_add_package_manage_to_authorized_user.rb

@@ -1,4 +1,4 @@
-class AddPackageManageToAuthorizedUser < ActiveRecord::Migration
+class AddPackageManageToAuthorizedUser < ActiveRecord::Migration[5.0]
   def change
     add_column :authorized_user, :package_manage, :string
   end

db/migrate/20180830220045_create_uni_upd_mhld_errors.rb

@@ -1,4 +1,4 @@
-class CreateUniUpdMhldErrors < ActiveRecord::Migration
+class CreateUniUpdMhldErrors < ActiveRecord::Migration[5.0]
   def change
     create_table :uni_upd_mhld_errors do |t|
       t.integer :batch_id

db/migrate/20181119225853_create_package_files.rb

@@ -1,4 +1,4 @@
-class CreatePackageFiles < ActiveRecord::Migration
+class CreatePackageFiles < ActiveRecord::Migration[5.0]
   def change
     create_table :vnd_files_gen do |t|
       t.string :package_id

db/migrate/20181121214017_create_vnd_runlogs.rb

@@ -1,4 +1,4 @@
-class CreateVndRunlogs < ActiveRecord::Migration
+class CreateVndRunlogs < ActiveRecord::Migration[5.0]
   def change
     create_table :vnd_runlog do |t|
       t.datetime :run_date