.rubocop_todo.yml regenned

.rubocop_todo.yml

@@ -1,20 +1,19 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-11-28 17:43:48 -0800 using RuboCop version 0.50.0.
+# on 2018-03-05 17:56:25 -0800 using RuboCop version 0.50.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 25
+# Offense count: 15
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedHashRocketStyle, SupportedHashRocketStyles, EnforcedColonStyle, SupportedColonStyles, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
 # SupportedHashRocketStyles: key, separator, table
 # SupportedColonStyles: key, separator, table
 # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
 Layout/AlignHash:
   Exclude:
-    - 'spec/unit_tests/moab/file_group_difference_spec.rb'
     - 'spec/unit_tests/serializer/serializable_spec.rb'
 
 # Offense count: 40
@@ -69,7 +68,7 @@ Layout/EmptyLines:
     - 'lib/moab/version_metadata_event.rb'
     - 'spec/unit_tests/moab/storage_object_spec.rb'
 
-# Offense count: 32
+# Offense count: 31
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: empty_lines, no_empty_lines
@@ -83,11 +82,10 @@ Layout/EmptyLinesAroundBlockBody:
 Layout/EmptyLinesAroundClassBody:
   Enabled: false
 
-# Offense count: 2
+# Offense count: 1
 # Cop supports --auto-correct.
 Layout/EmptyLinesAroundMethodBody:
   Exclude:
-    - 'lib/moab/bagger.rb'
     - 'spec/spec_helper.rb'
 
 # Offense count: 53
@@ -97,12 +95,11 @@ Layout/EmptyLinesAroundMethodBody:
 Layout/EmptyLinesAroundModuleBody:
   Enabled: false
 
-# Offense count: 11
+# Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
   Exclude:
-    - 'lib/moab/bagger.rb'
     - 'lib/moab/file_instance.rb'
     - 'lib/moab/file_instance_difference.rb'
     - 'lib/moab/signature_catalog.rb'
@@ -111,7 +108,7 @@ Layout/ExtraSpacing:
     - 'spec/unit_tests/moab/file_group_difference_spec.rb'
     - 'spec/unit_tests/moab/file_group_spec.rb'
 
-# Offense count: 16
+# Offense count: 14
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
 # SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
@@ -123,7 +120,6 @@ Layout/FirstParameterIndentation:
     - 'lib/stanford/content_inventory.rb'
     - 'spec/features/metadata/version_metadata_spec.rb'
     - 'spec/spec_helper.rb'
-    - 'spec/unit_tests/moab/file_group_difference_spec.rb'
     - 'spec/unit_tests/moab/file_group_spec.rb'
     - 'spec/unit_tests/moab/signature_catalog_spec.rb'
     - 'spec/unit_tests/serializer/serializable_spec.rb'
@@ -141,14 +137,13 @@ Layout/IndentArray:
     - 'spec/unit_tests/moab/storage_object_version_spec.rb'
     - 'spec/unit_tests/stanford/content_inventory_spec.rb'
 
-# Offense count: 45
+# Offense count: 43
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces
 Layout/IndentHash:
   Exclude:
     - 'lib/moab/storage_object_version.rb'
-    - 'spec/unit_tests/moab/file_group_difference_spec.rb'
     - 'spec/unit_tests/moab/file_inventory_difference_spec.rb'
     - 'spec/unit_tests/moab/file_inventory_spec.rb'
     - 'spec/unit_tests/moab/signature_catalog_spec.rb'
@@ -178,7 +173,7 @@ Layout/IndentationWidth:
     - 'lib/stanford/content_inventory.rb'
     - 'spec/unit_tests/moab/file_signature_spec.rb'
 
-# Offense count: 16
+# Offense count: 15
 # Cop supports --auto-correct.
 Layout/LeadingCommentSpace:
   Exclude:
@@ -189,7 +184,6 @@ Layout/LeadingCommentSpace:
     - 'lib/serializer/serializable.rb'
     - 'spec/features/metadata/version_metadata_spec.rb'
     - 'spec/spec_helper.rb'
-    - 'spec/unit_tests/moab/file_group_difference_spec.rb'
     - 'spec/unit_tests/serializer/manifest_spec.rb'
 
 # Offense count: 4
@@ -216,14 +210,14 @@ Layout/MultilineMethodCallIndentation:
 Layout/SpaceAfterComma:
   Enabled: false
 
-# Offense count: 69
+# Offense count: 70
 # Cop supports --auto-correct.
 # Configuration parameters: SupportedStyles.
 # SupportedStyles: space, no_space
 Layout/SpaceAroundEqualsInParameterDefault:
   EnforcedStyle: no_space
 
-# Offense count: 231
+# Offense count: 145
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment.
 Layout/SpaceAroundOperators:
@@ -237,7 +231,7 @@ Layout/SpaceAroundOperators:
 Layout/SpaceBeforeBlockBraces:
   Enabled: false
 
-# Offense count: 155
+# Offense count: 150
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space
@@ -305,7 +299,7 @@ Lint/RescueException:
   Exclude:
     - 'lib/moab/file_group.rb'
 
-# Offense count: 3
+# Offense count: 2
 Lint/RescueWithoutErrorClass:
   Exclude:
     - 'lib/moab/bagger.rb'
@@ -318,14 +312,14 @@ Lint/UnusedBlockArgument:
   Exclude:
     - 'spec/spec_helper.rb'
 
-# Offense count: 30
+# Offense count: 32
 Metrics/AbcSize:
   Max: 117
 
-# Offense count: 97
+# Offense count: 99
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/BlockLength:
-  Max: 515
+  Max: 513
 
 # Offense count: 10
 # Configuration parameters: CountComments.
@@ -336,7 +330,7 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 10
 
-# Offense count: 45
+# Offense count: 52
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 89
@@ -391,18 +385,18 @@ RSpec/BeforeAfterAll:
 RSpec/DescribeClass:
   Enabled: false
 
-# Offense count: 142
+# Offense count: 149
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Enabled: false
 
-# Offense count: 11
+# Offense count: 12
 # Configuration parameters: SupportedStyles.
 # SupportedStyles: implicit, each, example
 RSpec/HookArgument:
   EnforcedStyle: each
 
-# Offense count: 552
+# Offense count: 553
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Enabled: false
@@ -419,7 +413,7 @@ RSpec/LetBeforeExamples:
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 136
+# Offense count: 143
 RSpec/MultipleExpectations:
   Max: 14
 
@@ -566,7 +560,7 @@ Style/GuardClause:
     - 'lib/moab/storage_repository.rb'
     - 'lib/serializer/serializable.rb'
 
-# Offense count: 335
+# Offense count: 236
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
@@ -578,12 +572,11 @@ Style/IfInsideElse:
   Exclude:
     - 'lib/moab/file_inventory.rb'
 
-# Offense count: 3
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.
 Style/IfUnlessModifier:
   Exclude:
-    - 'lib/moab/bagger.rb'
     - 'lib/moab/file_group_difference.rb'
     - 'lib/moab/storage_object.rb'
 
@@ -639,23 +632,21 @@ Style/ParallelAssignment:
   Exclude:
     - 'lib/serializer/serializable.rb'
 
-# Offense count: 6
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: AllowSafeAssignment.
 Style/ParenthesesAroundCondition:
   Exclude:
-    - 'lib/moab/bagger.rb'
     - 'lib/moab/file_manifestation.rb'
     - 'lib/moab/file_signature.rb'
     - 'lib/moab/verification_result.rb'
     - 'spec/unit_tests/moab/verification_result_spec.rb'
 
-# Offense count: 9
+# Offense count: 8
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
-    - 'Rakefile'
     - 'lib/moab/file_group.rb'
     - 'lib/moab/file_group_difference.rb'
     - 'lib/moab/file_inventory.rb'
@@ -730,7 +721,7 @@ Style/RescueModifier:
   Exclude:
     - 'lib/stanford/content_inventory.rb'
 
-# Offense count: 4
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: SupportedStyles.
 # SupportedStyles: use_perl_names, use_english_names
@@ -745,7 +736,7 @@ Style/StringLiteralsInInterpolation:
   Exclude:
     - 'spec/unit_tests/moab/storage_object_version_spec.rb'
 
-# Offense count: 6
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize, SupportedStyles.
 # SupportedStyles: percent, brackets
@@ -801,7 +792,7 @@ Style/WordArray:
   EnforcedStyle: percent
   MinSize: 8
 
-# Offense count: 8
+# Offense count: 7
 # Cop supports --auto-correct.
 Style/ZeroLengthPredicate:
   Exclude: