Update #key_dates accessor to handle ranges

sul-dlss · Dec 12, 2017 · d19a89a · d19a89a
1 parent 1d15fa9
commit d19a89a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/mods/origin_info.rb b/lib/mods/origin_info.rb
@@ -13,7 +13,9 @@ def dates
     end
 
     def key_dates
-      dates.select { |x| x.keyDate == 'yes' }
+      d = dates.select { |x| x.keyDate == 'yes' }
+
+      d += dates.select { |x| x.point == 'end' && d.any? { |date| date.name == x.name && date.point == 'start' } }
     end
   end
 end
diff --git a/spec/origin_info_spec.rb b/spec/origin_info_spec.rb
@@ -249,6 +249,11 @@
             @mods_rec.from_str("<mods #{@ns_decl}><originInfo><dateCreated>other date</dateCreated><dateCreated keyDate='yes'>key date</dateCreated></originInfo></mods>")
             expect(@mods_rec.origin_info.as_object.first.key_dates.first.text).to eq 'key date'
           end
+          it 'should extract a date range when the keyDate attribute is on the start of the range' do
+            @mods_rec.from_str("<mods #{@ns_decl}><originInfo><dateCreated point='end'>other date</dateCreated><dateCreated keyDate='yes' point='start'>key date</dateCreated></originInfo></mods>")
+            expect(@mods_rec.origin_info.as_object.first.key_dates.first.text).to eq 'key date'
+            expect(@mods_rec.origin_info.as_object.first.key_dates.last.text).to eq 'other date'
+          end
         end
       end