Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict allowable paths for bundle input dir #387

Closed
jmartin-sul opened this issue Oct 1, 2018 · 3 comments · Fixed by #399
Closed

restrict allowable paths for bundle input dir #387

jmartin-sul opened this issue Oct 1, 2018 · 3 comments · Fixed by #399
Assignees

Comments

@jmartin-sul
Copy link
Member

we should restrict to the mount paths on the pre-assembly box.

@blalbrit can provide a whitelist of valid input paths.

@jmartin-sul
Copy link
Member Author

this is something of a security issue. we also want to make sure they don't do sneaky things like going from a whitelisted root path but then backing up using relative dirs via .. etc.

@jmartin-sul
Copy link
Member Author

for tests, the rspec spinup can add the fixture paths to the whitelist. then, don't have to do anything env dependent in regular app code.

@blalbrit
Copy link
Contributor

blalbrit commented Oct 1, 2018

The active mounts are listed at https://consul.stanford.edu/display/CollAcc/Content+Mount+Paths (mount path column for the path that is accessed from the prod preassembly box)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants