Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy dev config #130

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Add a dummy dev config #130

merged 1 commit into from
Aug 29, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Aug 28, 2018

This allows bundle exec rails console to succeed on a local system.

This allows `bundle exec rails console` to succeed on a local system.
@atz atz added the review label Aug 28, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 450

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.899%

Totals Coverage Status
Change from base Build 421: 0.0%
Covered Lines: 1341
Relevant Lines: 2132

💛 - Coveralls

Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndushay
Copy link
Contributor

ndushay commented Aug 29, 2018

Hrmm - I had to include require dor-services as the first line for this to work.

@SaravShah
Copy link
Contributor

SaravShah commented Aug 29, 2018

yup @ndushay, need to require 'dor-services' for this to work. There is some dependency loading issue, when adding require 'dor-services' to application.rb you'd think you would not have to require in development.rb, but we have to. Same pattern in test.rb (added in my PR #125 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants