Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to PRE_ASSEMBLY_ROOT, it's just Rails.root now #222

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Remove references to PRE_ASSEMBLY_ROOT, it's just Rails.root now #222

merged 1 commit into from
Sep 7, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Sep 7, 2018

No description provided.

@atz atz added the review label Sep 7, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 704

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 66.473%
Files with Coverage Reduction New Missed Lines %
app/lib/bundle_context_temporary.rb 4 95.29%
Totals Coverage Status
Change from base Build 702: 0.1%
Covered Lines: 573
Relevant Lines: 862
💛 - Coveralls

@jmartin-sul jmartin-sul merged commit 8b5ebeb into master Sep 7, 2018
@jmartin-sul jmartin-sul deleted the rails_root branch September 7, 2018 23:31
@jmartin-sul jmartin-sul removed the review label Sep 7, 2018
jmartin-sul added a commit that referenced this pull request Sep 8, 2018
@jmartin-sul
remove definition of unreferenced PRE_ASSEMBLY_ROOT var (replaced in #…
ed403b6 
…222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartin-sul jmartin-sul jmartin-sul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atz @coveralls @jmartin-sul