clean up the csv import functionality

[jmartin-sul]

• centralize this shared functionality to a file in app/lib, move tests to corresponding spec file, have everything that needs the functionality use the app/lib method
• give it a slighty better name
• stop delegating unnecessarily in Bundle, and stop calling it via Bundle. remove duplicate test in bundle_spec.rb
• excise unnecessary redefinition and tests in bundle_context_temporary and its _spec
• switch to using the more standard ArgumentError instead of the custom BundleUsageError

[coveralls]

Pull Request Test Coverage Report for Build 747

• 10 of 10 (100.0%) changed or added relevant lines in 4 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.5%) to 67.528%

---

Files with Coverage Reduction	New Missed Lines	%
app/lib/pre_assembly/logging.rb	2	92.31%

Totals
Change from base Build 745:	-0.5%
Covered Lines:	601
Relevant Lines:	890

---

💛 - Coveralls

[ndushay]

I thought this was going to be a private method in BundleContext, which is the only user? Is it split out because we're getting rid of BundleContextTemporary and this makes that easier?

[jmartin-sul]

when i went to make it a private method, it turned out there was one other consumer. the consumer was not Bundle, but something else that called the import method via Bundle (which used to be its home). that might've been the reason for the delegation in the first place, not totally sure.

so my comment on the last PR was wrong, it can't be a private method since smpl.rb still uses it (via Bundle):
https://github.com/sul-dlss/pre-assembly/blob/master/app/lib/pre_assembly/smpl.rb#L49
https://github.com/sul-dlss/pre-assembly/blob/master/app/lib/pre_assembly/smpl.rb#L42
https://github.com/sul-dlss/pre-assembly/blob/master/app/lib/pre_assembly/bundle.rb#L65

[jmartin-sul]

re: BundleContextTemporary, i just did the minimum there to not have the tests break, since the plan is to remove that anyway. but the decision to centralize to app/lib was driven by Smpl.initialize, and not BundleContextTemporary.

[ndushay]

fair nuff.