Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add okcomputer #334

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Add okcomputer #334

merged 1 commit into from
Sep 21, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Sep 20, 2018

Baseline checks are better than none, to start.

Fixes #283

@atz
Add okcomputer
3b5bca6 
Baseline checks are better than none, to start.

Fixes #283
@atz atz added the review label Sep 20, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1047

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 60.063%
Totals Coverage Status
Change from base Build 1037: 0.1%
Covered Lines: 576
Relevant Lines: 959
💛 - Coveralls

@SaravShah
Copy link
Contributor

Should I create another ticket that says what other okcomputerchecks do we want, other than the default checks?

@jmartin-sul jmartin-sul merged commit e125ae6 into master Sep 21, 2018
@jmartin-sul jmartin-sul deleted the ok_computer branch September 21, 2018 17:01
@jmartin-sul jmartin-sul mentioned this pull request Sep 21, 2018
Closed
@jmartin-sul
Copy link
Member

@SaravShah i went ahead and filed #339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartin-sul jmartin-sul jmartin-sul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atz @coveralls @SaravShah @jmartin-sul