Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic preassembly_job wiring and tests #353

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Basic preassembly_job wiring and tests #353

merged 1 commit into from
Sep 25, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Sep 25, 2018

This punts on the question of "other" log output and just uses the progress_log_file as the output. This is enough to get jobs running and persist info about whether or not the job completed.

Closes #85

@atz
Basic preassembly_job wiring and tests
f60d1bc 
This punts on the question of "other" log output and just uses the
`progress_log_file` as the output.  This is enough to get jobs running
and persist info about whether or not the job completed.
@atz atz added the review label Sep 25, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1104

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 64.599%
Totals Coverage Status
Change from base Build 1100: 0.3%
Covered Lines: 531
Relevant Lines: 822
💛 - Coveralls

@jmartin-sul jmartin-sul merged commit a9a3a8d into master Sep 25, 2018
@jmartin-sul jmartin-sul deleted the pa_job branch September 25, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartin-sul jmartin-sul jmartin-sul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atz @coveralls @jmartin-sul