Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove manifest_cols #375

Merged
merged 1 commit into from
Sep 28, 2018
Merged

remove manifest_cols #375

merged 1 commit into from
Sep 28, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Sep 28, 2018

Follows #373 (one distinct commit)

Fixes #329

@atz atz added the review label Sep 28, 2018
@coveralls
Copy link

coveralls commented Sep 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1216

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 89.338%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/lib/pre_assembly/bundle.rb 4 5 80.0%
Totals Coverage Status
Change from base Build 1209: -0.08%
Covered Lines: 486
Relevant Lines: 544
💛 - Coveralls

@SaravShah
Copy link
Contributor

rebase please :)

@atz
Remove manifest_cols
4e58d29 
These were hardcoded, never changed.  Not necessary to have indirectly
via a hash via a method, then.

Fixes #329
@jmartin-sul jmartin-sul merged commit ed42db9 into master Sep 28, 2018
@jmartin-sul jmartin-sul deleted the manifest_cols branch September 28, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartin-sul jmartin-sul jmartin-sul approved these changes

@SaravShah SaravShah SaravShah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@atz @coveralls @SaravShah @jmartin-sul