Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC index, kaminari templates and a bugfix #407

Merged
merged 3 commits into from
Oct 5, 2018
Merged

BC index, kaminari templates and a bugfix #407

merged 3 commits into from
Oct 5, 2018

Commits on Oct 5, 2018

  1. Generate kaminari config and bootstrap4 views

    @atz
    atz committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    a19eb06 View commit details
    Browse the repository at this point in the history

  2. BC index view, w/ revised BC show template 

    - buttons are now part of the view for a BC, meaning they are included
via reuse by JobRun#show and BundleContext#index here.
- route added
- minimal test
- BC index does pagination when needed

Overall, seems like we could use a NavBar with links for:
- "Jobs"
- "Projects"
- "New Project"
    @atz
    atz committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    1be383a View commit details
    Browse the repository at this point in the history

  3. Don't double-assign constants 

    Otherwise, we get warnings on every spin-up:
```
/Users/atz/repos/pre-assembly/config/initializers/load_config.rb:2: warning: already initialized constant ALLOWABLE_BUNDLE_DIRS
/Users/atz/repos/pre-assembly/config/initializers/load_config.rb:1: warning: previous definition of ALLOWABLE_BUNDLE_DIRS was here
```
    @atz
    atz committed Oct 5, 2018
    Configuration menu
    Copy the full SHA
    ae6a133 View commit details
    Browse the repository at this point in the history