Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "experiment" script and awesome_print dependency #75

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Aug 20, 2018

awesome_print was only used by this one exploratory script from 2012.
This repo should be more production code, less developer one-offs.

awesome_print was only used by this one exploratory script from 2012.
This repo should be more production code, less developer one-offs.
@atz atz added the review label Aug 20, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 287

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 59.374%

Totals Coverage Status
Change from base Build 281: 2.6%
Covered Lines: 1251
Relevant Lines: 2107

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 287

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 59.374%

Totals Coverage Status
Change from base Build 281: 2.6%
Covered Lines: 1251
Relevant Lines: 2107

💛 - Coveralls

Copy link
Contributor

@jermnelson jermnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to remove awesome_print and removing this script.

@jermnelson jermnelson merged commit 10c1a01 into master Aug 20, 2018
@jermnelson jermnelson removed the review label Aug 20, 2018
@jermnelson jermnelson deleted the experiment_over branch August 20, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants