pohandler: ensure we don't output results if db update fails

sul-dlss · Nov 29, 2017 · d01defc · d01defc
1 parent a8afa66
commit d01defc
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/app/services/preserved_object_handler.rb b/app/services/preserved_object_handler.rb
@@ -159,7 +159,7 @@ def create_db_objects(status, validated=false)
       end
       PreservedCopy.create!(pc_attrs)
     end
-    results << result_hash(CREATED_NEW_OBJECT)
+    results << result_hash(CREATED_NEW_OBJECT) unless create_results.include?(DB_UPDATE_FAILED)
     results.concat(create_results)
   end
 

diff --git a/spec/services/preserved_object_handler_create_spec.rb b/spec/services/preserved_object_handler_create_spec.rb
@@ -69,6 +69,9 @@
           it "exception's message" do
             expect(results).to include(a_hash_including(result_code => a_string_matching('foo')))
           end
+          it 'does NOT get CREATED_NEW_OBJECT message' do
+            expect(results).to include(hash_not_including(PreservedObjectHandler::CREATED_NEW_OBJECT))
+          end
         end
       end
 

diff --git a/spec/services/preserved_object_handler_update_version_spec.rb b/spec/services/preserved_object_handler_update_version_spec.rb
@@ -242,6 +242,10 @@
               it "exception's message" do
                 expect(results).to include(a_hash_including(result_code => a_string_matching('foo')))
               end
+              it 'does NOT get UPDATED_DB_OBJECT message' do
+                expect(results).to include(hash_not_including(PreservedObjectHandler::UPDATED_DB_OBJECT))
+                expect(results).to include(hash_not_including(PreservedObjectHandler::UPDATED_DB_OBJECT_TIMESTAMP_ONLY))
+              end
             end
           end
         end
@@ -282,6 +286,10 @@
               it "exception's message" do
                 expect(results).to include(a_hash_including(result_code => a_string_matching('foo')))
               end
+              it 'does NOT get UPDATED_DB_OBJECT message' do
+                expect(results).to include(hash_not_including(PreservedObjectHandler::UPDATED_DB_OBJECT))
+                expect(results).to include(hash_not_including(PreservedObjectHandler::UPDATED_DB_OBJECT_TIMESTAMP_ONLY))
+              end
             end
           end
         end