Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCC: use settings.yml instead of hardcoding #21

Closed
ndushay opened this issue Aug 23, 2017 · 0 comments
Closed

PCC: use settings.yml instead of hardcoding #21

ndushay opened this issue Aug 23, 2017 · 0 comments
Assignees

Comments

@ndushay
Copy link
Contributor

ndushay commented Aug 23, 2017

we have a branch (show-action-naomi) with a clear need for some settings so this can be set up off that branch (or master, if PR #25 is merged)

e.g. need config/settings.yml with values to be used by config/application.rb

We want to do the same sort of configuration approach we use in most rails apps, with the config gem and config/settings.yml with defaults and config/settings/[env].yml also with defaults, with no sensitive info in config/settings/production.yml. dlme project might be a good example.

This will set us up for #4, where we put VM specific or sensitive information into shared_configs and hook it up so rails app finds it as if it was in config/settings/[env].yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants