show action initial implementation #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
force-pushed
the
show-action-naomi
branch
3 times, most recently
from
156cbaf
to
8958c87
Compare
|
Coverage increased (+19.4%) to 56.41% when pulling 8958c87e56b6bf16601df8c6c43ef79d536b0b5f on show-action-naomi into 68fd879 on master. |
jmartin-sul
approved these changes
Aug 24, 2017
|
In the moab_storage_controller, Line 17 maybe change the name of the key to current_version? |
|
So am I hearing that both @SaravShah and @jmartin-sul are in favor of renaming to |
ndushay
force-pushed
the
show-action-naomi
branch
from
8958c87
to
beb3779
Compare
|
@jmartin-sul @SaravShah okay - I changed it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea was to get a very basic (crude, even) show action working so we could split out tickets to do additional work - I believe this PR achieves that.
I have indicated spots in the code that I know need more attention, and created github issues for them. Please leave a comment if you see more things that we need to change.
@SaravShah helped with this.
I included some other refactoring which I can split out into a separate PR if you deem it worth the trouble.
Resolves #12