Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert C2M to worker Queue #1062

Merged
merged 6 commits into from
Aug 9, 2018
Merged

Convert C2M to worker Queue #1062

merged 6 commits into from
Aug 9, 2018

Commits on Aug 8, 2018

  1. Replace "class level" c2m logic, add c2m Job

    @atz
    atz committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    62e9c33 View commit details
    Browse the repository at this point in the history

  2. Ensure order to make ordered comparison

    @atz
    atz committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    acafe6f View commit details
    Browse the repository at this point in the history

  3. Add preserved_object_fixture factory to replace load_fixture_moabs

    @atz
    atz committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    3cbc292 View commit details
    Browse the repository at this point in the history

  4. Rename c2m "instance" spec and convert from load_fixtures_helper 

    - Now uses factory that is fixture-aware.
- Use single `AuditResults` instance double for all cases.
- Stop intercepting `UnrelatedModel.new(...)` and just set the double
object directly into the subject where needed.  Then set expecations on
the model's getter (instead of on the double independently).
- More better `before` blocks
    @atz
    atz committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    c1a34f0 View commit details
    Browse the repository at this point in the history

  5. Tests for the new job and MSR method wrapping it

    @atz
    atz committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    6660573 View commit details
    Browse the repository at this point in the history

  6. Update README to match async C2M

    @atz
    atz committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    4ff63aa View commit details
    Browse the repository at this point in the history