This repository has been archived by the owner on Oct 15, 2021. It is now read-only.
Show a list of all of a persons publications on the person show page #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
justinlittman
suggested changes
Nov 8, 2018
Gemfile.lock
Outdated
| @@ -1,6 +1,7 @@ | |||
| GIT | |||
| remote: https://github.com/projectblacklight/blacklight.git | |||
| revision: 5284e21ddd2785923cd1e3836925e1a250397c31 | |||
| revision: b3d53042bf4cbb4a472435999df5162503bde023 | |||
There was a problem hiding this comment.
Fetching https://github.com/projectblacklight/blacklight.git
fatal: Could not parse object 'b3d53042bf4cbb4a472435999df5162503bde023'.
Revision b3d53042bf4cbb4a472435999df5162503bde023 does not exist in the
repository https://github.com/projectblacklight/blacklight.git. Maybe you
misspelled it?
jcoyne
force-pushed
the
person-publications
branch
from
552ca78
to
e65aa3c
Compare
jcoyne
force-pushed
the
person-publications
branch
from
e65aa3c
to
d25c64e
Compare
|
I'd suggest that the publications should include publication date and be sorted in descending publication date order. cc @peetucket If going to do this, OK if part of this ticket or a separate ticket. |
|
@justinlittman if you want to expand the scope after the work is done, it makes sense to make a new ticket. |
|
Agreed publication date seems useful, I've created a new ticket: #188 |
justinlittman
approved these changes
Nov 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111