This repository has been archived by the owner on Oct 15, 2021. It is now read-only.
Display publications on the grants show page #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jcoyne
force-pushed
the
show-publications
branch
from
ddeb8ea
to
ac671f6
Compare
mjgiarlo
approved these changes
Nov 8, 2018
| @@ -160,12 +160,13 @@ class CatalogController < ApplicationController | |||
| pc.add_show_field 'subject_label_tsim', label: 'Subject' | |||
| pc.add_show_field 'link_ssim', label: 'Link' | |||
| pc.add_show_field 'publisher_label_tsim', label: 'Publisher' | |||
| pc.add_show_field 'Grants', label: 'Grant', accessor: :linked_grants | |||
| pc.add_show_field 'grants', label: 'Grant', accessor: :linked_grants | |||
There was a problem hiding this comment.
Should the label here be Grants, or are you thinking publications will be associated with only one grant?
There was a problem hiding this comment.
I suspect most will only have one grant...but we'll find out.
There was a problem hiding this comment.
Easy change to make later when we know more. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112