hooking up travis, coveralls, gemnasium, codeclimate, hound #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,5 @@ | |||
| require 'coveralls' | |||
| Coveralls.wear!('rails') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| require 'rubocop/rake_task' | ||
| RuboCop::RakeTask.new(:rubocop) | ||
|
|
||
| task default: [:spec, :rubocop] |
There was a problem hiding this comment.
Should the default be set outside of the begin/require block? It might be strange that the default would be different under different contexts.
|
1️⃣ minor comment. 👍 |
|
minor comment addressed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all with a no-op test.
connects to sul-dlss/media#7