Merge pull request #85 from sul-dlss/rubocop

Rubocop
sul-dlss · Jul 30, 2016 · a39dcf9 · a39dcf9
2 parents 7d5e4c7 + 7291591
commit a39dcf9
Show file tree

Hide file tree

Showing 30 changed files with 941 additions and 629 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,12 +1,375 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2015-11-17 14:05:33 -0800 using RuboCop version 0.35.1.
+# on 2016-07-29 17:24:44 -0700 using RuboCop version 0.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 34
+Metrics/AbcSize:
+  Max: 55
+
+# Offense count: 5
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 344
+
+# Offense count: 19
+Metrics/CyclomaticComplexity:
+  Max: 26
+
+# Offense count: 109
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 188
+
+# Offense count: 32
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 53
+
+# Offense count: 15
+Metrics/PerceivedComplexity:
+  Max: 22
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Performance/PushSplat:
+  Exclude:
+    - 'spec/date_parsing_spec.rb'
+
+# Offense count: 3
+RSpec/AnyInstance:
+  Exclude:
+    - 'spec/date_parsing_spec.rb'
+
+# Offense count: 13
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/date_parsing_spec.rb'
+    - 'spec/geo_spatial_spec.rb'
+    - 'spec/name_spec.rb'
+    - 'spec/origin_info_spec.rb'
+    - 'spec/physical_location_spec.rb'
+    - 'spec/searchworks_basic_spec.rb'
+    - 'spec/searchworks_format_spec.rb'
+    - 'spec/searchworks_pub_dates_spec.rb'
+    - 'spec/searchworks_spec.rb'
+    - 'spec/searchworks_subject_raw_spec.rb'
+    - 'spec/searchworks_subject_spec.rb'
+    - 'spec/searchworks_title_spec.rb'
+    - 'spec/sw_publication_spec.rb'
+
+# Offense count: 144
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/imprint_spec.rb'
+    - 'spec/name_spec.rb'
+    - 'spec/origin_info_spec.rb'
+    - 'spec/searchworks_format_spec.rb'
+    - 'spec/searchworks_pub_dates_spec.rb'
+    - 'spec/searchworks_spec.rb'
+    - 'spec/searchworks_subject_raw_spec.rb'
+    - 'spec/searchworks_subject_spec.rb'
+    - 'spec/searchworks_title_spec.rb'
+
+# Offense count: 106
+# Configuration parameters: CustomTransform, IgnoredWords.
+RSpec/ExampleWording:
+  Exclude:
+    - 'spec/searchworks_basic_spec.rb'
+    - 'spec/searchworks_spec.rb'
+    - 'spec/searchworks_subject_raw_spec.rb'
+    - 'spec/searchworks_subject_spec.rb'
+    - 'spec/searchworks_title_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: CustomTransform.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/imprint_spec.rb'
+    - 'spec/lib/stanford-mods/coordinate_spec.rb'
+
+# Offense count: 1081
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/physical_location_spec.rb'
+    - 'spec/searchworks_basic_spec.rb'
+    - 'spec/searchworks_format_spec.rb'
+    - 'spec/searchworks_spec.rb'
+    - 'spec/searchworks_subject_raw_spec.rb'
+    - 'spec/searchworks_subject_spec.rb'
+    - 'spec/searchworks_title_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: outdent, indent
+Style/AccessModifierIndentation:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: prefer_alias, prefer_alias_method
+Style/Alias:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
+# Offense count: 27
+# Cop supports --auto-correct.
+Style/AlignArray:
+  Exclude:
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'spec/imprint_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Style/AlignHash:
+  Exclude:
+    - 'spec/fixtures/searchworks_imprint_data.rb'
+    - 'spec/fixtures/searchworks_pub_date_data.rb'
+    - 'spec/fixtures/spotlight_pub_date_data.rb'
+
+# Offense count: 33
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+    - 'lib/stanford-mods/name.rb'
+    - 'lib/stanford-mods/origin_info.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'lib/stanford-mods/searchworks_subjects.rb'
+    - 'spec/name_spec.rb'
+
+# Offense count: 12
+# Cop supports --auto-correct.
+Style/BlockEndNewline:
+  Exclude:
+    - 'spec/name_spec.rb'
+
+# Offense count: 20
+# Cop supports --auto-correct.
+# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
+# SupportedStyles: case, end
+Style/CaseIndentation:
+  Exclude:
+    - 'lib/stanford-mods/searchworks.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/CommentIndentation:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+    - 'spec/fixtures/searchworks_imprint_data.rb'
+    - 'spec/fixtures/searchworks_pub_date_data.rb'
+    - 'spec/fixtures/spotlight_pub_date_data.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
+# SupportedStyles: assign_to_condition, assign_inside_condition
+Style/ConditionalAssignment:
+  Exclude:
+    - 'lib/stanford-mods/imprint.rb'
+    - 'lib/stanford-mods/origin_info.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+
+# Offense count: 5
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/stanford-mods/name.rb'
+    - 'lib/stanford-mods/origin_info.rb'
+    - 'lib/stanford-mods/physical_location.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'lib/stanford-mods/searchworks_subjects.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/EmptyCaseCondition:
+  Exclude:
+    - 'lib/stanford-mods/imprint.rb'
+
 # Offense count: 1
-Lint/UselessAssignment:
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty, nil, both
+Style/EmptyElse:
   Exclude:
-    - 'config/mappings_hash.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
+Style/FileName:
+  Exclude:
+    - 'lib/stanford-mods.rb'
+
+# Offense count: 2
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Exclude:
+    - 'lib/stanford-mods/date_parsing.rb'
+    - 'lib/stanford-mods/origin_info.rb'
+
+# Offense count: 2
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
+# Offense count: 205
+# Cop supports --auto-correct.
+Style/LineEndConcatenation:
+  Exclude:
+    - 'spec/fixtures/searchworks_imprint_data.rb'
+    - 'spec/fixtures/searchworks_pub_date_data.rb'
+    - 'spec/fixtures/spotlight_pub_date_data.rb'
+    - 'spec/origin_info_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/MethodName:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: symmetrical, new_line, same_line
+Style/MultilineArrayBraceLayout:
+  Exclude:
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'spec/imprint_spec.rb'
+
+# Offense count: 12
+# Cop supports --auto-correct.
+Style/MultilineBlockLayout:
+  Exclude:
+    - 'spec/name_spec.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented, indented_relative_to_receiver
+Style/MultilineMethodCallIndentation:
+  Exclude:
+    - 'spec/date_parsing_spec.rb'
+
+# Offense count: 882
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented
+Style/MultilineOperationIndentation:
+  Exclude:
+    - 'lib/stanford-mods/name.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'spec/fixtures/searchworks_imprint_data.rb'
+    - 'spec/fixtures/searchworks_pub_date_data.rb'
+    - 'spec/fixtures/spotlight_pub_date_data.rb'
+    - 'spec/origin_info_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
+# SupportedOctalStyles: zero_with_o, zero_only
+Style/NumericLiteralPrefix:
+  Exclude:
+    - 'spec/date_parsing_spec.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+Style/PerlBackrefs:
+  Exclude:
+    - 'lib/stanford-mods/date_parsing.rb'
+
+# Offense count: 2
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Style/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/stanford-mods/origin_info.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/PreferredHashMethods:
+  Exclude:
+    - 'lib/stanford-mods/searchworks.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'lib/stanford-mods/date_parsing.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'spec/searchworks_subject_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/RescueModifier:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: only_raise, only_fail, semantic
+Style/SignalException:
+  Exclude:
+    - 'lib/stanford-mods/origin_info.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles.
+# SupportedStyles: use_perl_names, use_english_names
+Style/SpecialGlobalVars:
+  EnforcedStyle: use_perl_names
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: respond_to, define_method
+Style/SymbolProc:
+  Exclude:
+    - 'lib/stanford-mods/searchworks.rb'
+    - 'lib/stanford-mods/searchworks_subjects.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
+# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
+Style/TrivialAccessors:
+  Exclude:
+    - 'lib/stanford-mods/searchworks.rb'
+
+# Offense count: 10
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/VariableName:
+  Exclude:
+    - 'lib/stanford-mods/imprint.rb'
+    - 'lib/stanford-mods/origin_info.rb'
+    - 'lib/stanford-mods/searchworks.rb'
+
+# Offense count: 125
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, MinSize, WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  EnforcedStyle: brackets
diff --git a/Rakefile b/Rakefile
@@ -10,12 +10,12 @@ rescue Bundler::BundlerError => e
   exit e.status_code
 end
 
-task :default => :ci
+task default: :ci
 
 desc "run continuous integration suite (tests, coverage, rubocop lint)"
-task :ci => [:rspec, :rubocop]
+task ci: [:rspec, :rubocop]
 
-task :spec => :rspec
+task spec: :rspec
 
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:rspec) do |spec|