Skip to content

Commit

Permalink
Better specify dependencies
Browse files Browse the repository at this point in the history
- Rails 5 breaks old rubies
- nokogiri is used by specs
- coveralls *should* be used by developers, not just test
  • Loading branch information
atz committed Jul 28, 2016
1 parent 274fd8f commit b8ece69
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 19 deletions.
4 changes: 0 additions & 4 deletions Gemfile
Expand Up @@ -7,9 +7,5 @@ group :test, :development do
gem 'rubocop', require: false
gem 'rubocop-rspec', require: false
gem 'pry-byebug', require: false, platform: [:ruby_20, :ruby_21]
end

group :test do
gem 'coveralls', require: false
# gem 'pry-byebug', require: false
end
21 changes: 6 additions & 15 deletions stanford-mods.gemspec
Expand Up @@ -12,29 +12,20 @@ Gem::Specification.new do |gem|

gem.extra_rdoc_files = ["LICENSE", "README.md"]
gem.files = `git ls-files`.split($\)
gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
gem.executables = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
gem.test_files = gem.files.grep(%r{^spec/})
gem.require_paths = ["lib"]

gem.add_dependency 'mods', '~> 2.0.2'
# active_support for .ordinalize, eg. 1 -> 1st, 2 -> 2nd for centuries
gem.add_dependency 'activesupport'

# Runtime dependencies
# gem.add_runtime_dependency 'nokogiri'
gem.add_dependency 'activesupport', '~> 4.2'

# Development dependencies
# Bundler WILL install these gems too if you've checked out from git and run 'bundle install'
# Bundler WILL NOT add these as dependencies if you gem install or add this gem to your Gemfile
gem.add_development_dependency "rake"
# docs
gem.add_development_dependency "rdoc"
gem.add_development_dependency "yard"
# tests
gem.add_development_dependency 'rake'
gem.add_development_dependency 'rdoc'
gem.add_development_dependency 'yard'
gem.add_development_dependency 'rspec'
# using coveralls with travis now
# gem.add_development_dependency 'simplecov'
# gem.add_development_dependency 'simplecov-rcov'
# gem.add_development_dependency 'ruby-debug19'

gem.add_development_dependency 'nokogiri'
end

0 comments on commit b8ece69

Please sign in to comment.