update js, css to indicate when pdf is selected #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Not really my call, but maybe bolded too would make it even more obvious? |
|
Since there isn't a non-color visual indicator of active state, I believe the active state color will need a 3:1 contrast ratio with both the background (white) and the inactive state color (black). https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast#user-interface-components |
dnoneill
force-pushed
the
2161-indicate-pdf
branch
from
52c1415
to
90b7c21
Compare
peetucket
approved these changes
Jun 6, 2024
Approved here: #2161 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2161
Based on @alundgard comments updated to be
