Update UV theme #880

camillevilla · 2018-04-27T00:07:51Z

@mejackreed First time updating sul-embed's UV. Is this what you would expect to see?

Includes sul-dlss-deprecated/uv-en-GB-theme#8: Hide hit counters in thumbnail panel

houndci-bot · 2018-04-27T00:08:01Z

public/uv-3/lib/iiif-metadata-component.js

-// iiif-metadata-component v1.1.6 https://github.com/iiif-commons/iiif-metadata-component#readme
-(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.iiifMetadataComponent = f()}})(function(){var define,module,exports;return (function(){function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s}return e})()({1:[function(require,module,exports){
+// iiif-metadata-component v1.1.4 https://github.com/iiif-commons/iiif-metadata-component#readme
+(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.iiifMetadataComponent = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){


Line is too long.
Missing "use strict" statement.
Strings must use singlequote.
Missing semicolon.
Expected '===' and instead saw '=='.
Expected an identifier and instead saw '='.
Expected an assignment or function call and instead saw an expression.
'i' was used before it was defined.

houndci-bot · 2018-04-27T00:08:01Z

public/uv-3/lib/iiif-gallery-component.js

-// iiif-gallery-component v1.1.4 https://github.com/iiif-commons/iiif-gallery-component#readme
-(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.iiifGalleryComponent = f()}})(function(){var define,module,exports;return (function(){function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s}return e})()({1:[function(require,module,exports){
+// iiif-gallery-component v1.1.3 https://github.com/iiif-commons/iiif-gallery-component#readme
+(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.iiifGalleryComponent = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){


Line is too long.
Missing "use strict" statement.
Strings must use singlequote.
Missing semicolon.
Expected '===' and instead saw '=='.
Expected an identifier and instead saw '='.
Expected an assignment or function call and instead saw an expression.
'i' was used before it was defined.

houndci-bot · 2018-04-27T00:08:02Z

public/uv-3/lib/iiif-av-component.js

+                var temporal = /t=([^&]+)/g.exec(canvasId);
+                if (temporal && temporal.length > 1) {
+                    var rangeTiming = temporal[1].split(',');
+                    var duration = new IIIFComponents.AVComponentObjects.Duration(Number(rangeTiming[0]), Number(rangeTiming[1]));


Line is too long.

houndci-bot · 2018-04-27T00:08:02Z

public/uv-3/lib/iiif-av-component.js

-                this.set({
-                    canvasId: this.canvasInstances[0].getCanvasId()
-                });
+            for (var i = 0; i < canvases.length; i++) {


'i' is already defined.

coveralls · 2018-04-27T00:11:57Z

Coverage remained the same at 95.558% when pulling fe6a447 on update-UV-theme into 62528d6 on master.

mejackreed

Just putting the request changes here so we can figure out the package version regression.

mejackreed · 2018-04-27T00:18:56Z

public/uv-3/lib/iiif-gallery-component.js

@@ -1,5 +1,5 @@
-// iiif-gallery-component v1.1.4 https://github.com/iiif-commons/iiif-gallery-component#readme
-(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.iiifGalleryComponent = f()}})(function(){var define,module,exports;return (function(){function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s}return e})()({1:[function(require,module,exports){
+// iiif-gallery-component v1.1.3 https://github.com/iiif-commons/iiif-gallery-component#readme


I'm seeing this drop back from v.1.1.4 to v1.1.3. Is your local uv repo up to date with origin/master? Maybe we need to rm -rf node_modules?

@mejackreed alrighty, I removed rm -rf node_modules and updated, and it looks like this package regression is gone.

houndci-bot · 2018-04-27T00:34:25Z

public/uv-3/lib/virtex.js

-// virtex v0.3.9 https://github.com/edsilv/virtex#readme
-(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.virtex = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
+// virtex v0.3.11 https://github.com/edsilv/virtex#readme
+(function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.virtex = f()}})(function(){var define,module,exports;return (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){


Line is too long.
Missing "use strict" statement.
Strings must use singlequote.
Missing semicolon.
Expected '===' and instead saw '=='.
Expected an identifier and instead saw '='.
Expected an assignment or function call and instead saw an expression.
'u' was used before it was defined.

houndci-bot · 2018-04-27T00:34:25Z

public/uv-3/lib/uv-virtex-extension-dependencies.js

@@ -1,7 +1,7 @@
 define(function() {
    return {
        sync: ['three.min'],
-        async: ['VRControls', 'VREffect', 'stats.min', 'OBJLoader', 'MTLLoader', 'PLYLoader', 'Detector', 'WebVR', 'virtex', 'iiif-metadata-component']
+        async: ['VRControls', 'VREffect', 'stats.min', 'OBJLoader', 'MTLLoader', 'PLYLoader', 'GLTFLoader', 'Detector', 'WebVR', 'virtex', 'iiif-metadata-component']


Line is too long.

houndci-bot · 2018-04-27T00:34:26Z

public/uv-3/lib/WebVR.js


+	getVRDisplay: function () {
+		console.warn( 'WEBVR.getVRDisplay has been deprecated.' );


Missing "use strict" statement.

houndci-bot · 2018-04-27T00:34:26Z

public/uv-3/lib/WebVR.js


-		return button;
+	getButton: function () {
+		console.warn( 'WEBVR.getButton has been deprecated.' );


Missing "use strict" statement.

houndci-bot · 2018-04-27T00:34:26Z

public/uv-3/lib/WebVR.js


-		}
+	getMessageContainer: function () {
+		console.warn( 'WEBVR.getMessageContainer has been deprecated.' );


Missing "use strict" statement.

houndci-bot · 2018-04-27T00:34:26Z

public/uv-3/lib/OBJLoader.js

+
+					} else {
+
+						mesh = new THREE.Mesh( buffergeometry, createdMaterials[ 0 ] );


'THREE' is not defined.
Too many errors. (97% scanned).

houndci-bot · 2018-04-27T00:34:27Z

public/uv-3/lib/OBJLoader.js

+
+					} else if ( isPoints ) {
+
+						mesh = new THREE.Points( buffergeometry, createdMaterials[ 0 ] );


'THREE' is not defined.

houndci-bot · 2018-04-27T00:34:27Z

public/uv-3/lib/OBJLoader.js

-					mesh = ( ! isLine ? new THREE.Mesh( buffergeometry, createdMaterials[ 0 ] ) : new THREE.LineSegments( buffergeometry, createdMaterials[ 0 ] ) );
+					if ( isLine ) {
+
+						mesh = new THREE.LineSegments( buffergeometry, createdMaterials[ 0 ] );


'THREE' is not defined.

houndci-bot · 2018-04-27T00:34:27Z

public/uv-3/lib/OBJLoader.js

+
+					} else {
+
+						mesh = new THREE.Mesh( buffergeometry, createdMaterials );


'THREE' is not defined.

houndci-bot · 2018-04-27T00:34:27Z

public/uv-3/lib/OBJLoader.js

+
+					} else if ( isPoints ) {
+
+						mesh = new THREE.Points( buffergeometry, createdMaterials );


'THREE' is not defined.

houndci-bot reviewed Apr 27, 2018

View reviewed changes

mejackreed suggested changes Apr 27, 2018

View reviewed changes

camillevilla force-pushed the update-UV-theme branch from ca30b2d to 2e84524 Compare April 27, 2018 00:27

Update UV theme

fe6a447

camillevilla force-pushed the update-UV-theme branch from 2e84524 to fe6a447 Compare April 27, 2018 00:34

houndci-bot reviewed Apr 27, 2018

View reviewed changes

mejackreed approved these changes Apr 27, 2018

View reviewed changes

mejackreed merged commit 90c61ae into master Apr 27, 2018

mejackreed deleted the update-UV-theme branch April 27, 2018 18:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update UV theme #880

Update UV theme #880

camillevilla commented Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

coveralls commented Apr 27, 2018 •

edited

mejackreed left a comment

mejackreed Apr 27, 2018

camillevilla Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018

houndci-bot Apr 27, 2018


		getVRDisplay: function () {
		console.warn( 'WEBVR.getVRDisplay has been deprecated.' );


		} else {

		mesh = new THREE.Mesh( buffergeometry, createdMaterials[ 0 ] );


		} else if ( isPoints ) {

		mesh = new THREE.Points( buffergeometry, createdMaterials[ 0 ] );

Update UV theme #880

Update UV theme #880

Conversation

camillevilla commented Apr 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Apr 27, 2018 • edited

mejackreed left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Apr 27, 2018 •

edited