Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap form column definitions. #66

Merged
merged 1 commit into from Apr 21, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/helpers/application_helper.rb
Expand Up @@ -9,15 +9,15 @@ def bootstrap_form_layout_options
end

def label_column_class
'col-xs-2'
'col-sm-3'
end

def label_column_offset_class
'col-xs-offset-2'
'col-sm-offset-3'
end

def content_column_class
'col-xs-10'
'col-sm-9'
end

def send_request_via_login_button
Expand Down
6 changes: 3 additions & 3 deletions spec/helpers/application_helper_spec.rb
Expand Up @@ -12,17 +12,17 @@
expect(options[:layout]).to eq :horizontal
end
it 'should define a custom column class' do
expect(label_column_class).to eq 'col-xs-2'
expect(label_column_class).to eq 'col-sm-3'
expect(options[:label_col]).to eq label_column_class
end
it 'should define a custom column class' do
expect(content_column_class).to eq 'col-xs-10'
expect(content_column_class).to eq 'col-sm-9'
expect(options[:control_col]).to eq content_column_class
end
end
describe '#label_column_offset_class' do
it 'should be defined to help when offseting non-labeled form elements (e.g. buttons)' do
expect(label_column_offset_class).to eq 'col-xs-offset-2'
expect(label_column_offset_class).to eq 'col-sm-offset-3'
end
end
describe '#send_request_via_login_button' do
Expand Down