Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up project skeleton, gradle, travis #12

Merged
merged 9 commits into from
May 2, 2017
Merged

set up project skeleton, gradle, travis #12

merged 9 commits into from
May 2, 2017

Conversation

ndushay
Copy link
Contributor

@ndushay ndushay commented May 1, 2017

@tingulfsen we did something useful - please merge

closes #8
closes #9
closes #10
closes #11

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4ecd17c5d138c0195311aee3e9ecb09c38fa760b on setup into ** on master**.

@ndushay
Copy link
Contributor Author

ndushay commented May 1, 2017

Note that 67% coverage refers to 2 out of 3 lines of code that coveralls is counting, one of which is a class declaration and one of which is a closing brace!

@ndushay ndushay requested a review from tingulfsen May 1, 2017 22:51
@@ -0,0 +1,8 @@
package edu.stanford.dlss;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a web archiving package? E.g. src.edu.stanford.dlss.webarchiving or something like that? Like we did with edu.stanford.dlss.wowza for embed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, can do.

language: java

jdk:
- openjdk7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we check with LOCKSS that OpenJDK and Java version 7 is the best choice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenJDK 7 is what is currently on was-downloader, and I had the impression that was going to be the java installed on the new VMs.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 019cbb381e041ca5df38c7baf4bbbecfe312d633 on setup into ** on master**.

@ndushay
Copy link
Contributor Author

ndushay commented May 2, 2017

changed package name to edu.stanford.dlss.was as requested.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6b7579f on setup into ** on master**.

@tingulfsen tingulfsen merged commit a4697c2 into master May 2, 2017
@ndushay ndushay deleted the setup branch May 3, 2017 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants