This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
Update AuthBackend #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 23, 2016 12:58
Current coverage is 93.65% (diff: 100%)@@ master #7 diff @@
==========================================
Files 8 8
Lines 54 63 +9
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 50 59 +9
Misses 4 4
Partials 0 0
|
|
@brendonjohn cool! 👍 thank you. Today in the evening I'll make a release then, if you have something to improve or add then please propose. |
|
Thanks! |
peterbe
reviewed
Sep 29, 2016
| user_id = kwargs.get('user_id') | ||
|
|
||
| if user_id is None: | ||
| raise ValueError(_('user_id can\'t be blank!')) |
There was a problem hiding this comment.
These two lines feel mismatching. If user_id='' then the ValueError won't be raised.
There was a problem hiding this comment.
@peterbe thank you 👍 will fix it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've combined my changes into one PR so that you don't have to resolve a merge conflict.
This is to fix #4 and #5
AUTH0_USER_INFO_KEYSwhich contains the common user info properties that will always be provided by auth0.user_idis used instead of nicknameemailhas been dropped as a requirement as this is not always provided by auth0I considered that a users profile could be updated at the time of authenticating, but figure this would make the authentication process needlessly complex.
Please let me know what you think.
Thanks!