Add BC layer for track-total-hits #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
hotfix/track-total-results
branch
from
52d9b53
to
d823969
Compare
wachterjohannes
force-pushed
the
hotfix/track-total-results
branch
from
d823969
to
05dcc6c
Compare
alexander-schranz
approved these changes
Nov 18, 2021
Resources/doc/installation.md
Outdated
| @@ -37,6 +37,17 @@ sulu_route: | |||
| parent: '{object.getParent().getRoutePath()}' | |||
|
|
|||
| ongr_elasticsearch: | |||
| # If you expect more than 10000 articles you have to set the `max_result_window` to an appropriate number | |||
There was a problem hiding this comment.
need to be added also to the recipe: https://github.com/symfony/recipes-contrib/blob/master/sulu/article-bundle/2.0/config/packages/sulu_article.yaml
wachterjohannes
force-pushed
the
hotfix/track-total-results
branch
from
05dcc6c
to
6b1c24c
Compare
alexander-schranz
approved these changes
Nov 18, 2021
alexander-schranz
added
the
bug
This was referenced Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR set the parameter
track_total_hitsto allow pagination in the admin which Elasticsearch ^7.0Why?
If not set until 7.0 elasticsearch limits the total in the response to 10000 because of the change of the default value.
To Do