Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw NotAcceptableHttpException if template request format does not exists #679

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

FlorianKoerner
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

A request format for which the template is not available throws a Twig\Error\LoaderError. An HttpException would be better.

See also:

@FlorianKoerner FlorianKoerner changed the title Throw NotAcceptableHttpException if template request format not exists Throw NotAcceptableHttpException if template request format does not exists Jun 13, 2024
@alexander-schranz alexander-schranz added the bug Error or unexpected behavior of already existing functionality label Jun 20, 2024
@alexander-schranz
Copy link
Member

This make sense. Can you rebase to check if that fixes the PHP Lint errors?

@alexander-schranz alexander-schranz merged commit 343d441 into sulu:2.6 Jun 28, 2024
8 checks passed
@alexander-schranz
Copy link
Member

@FlorianKoerner Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants