Fix PHPStan issues

sulu · May 16, 2024 · 552648a · 552648a
1 parent 5d476c6
commit 552648a
Show file tree

Hide file tree

Showing 11 changed files with 43 additions and 29 deletions.
diff --git a/Content/Application/ContentMerger/ContentMerger.php b/Content/Application/ContentMerger/ContentMerger.php
@@ -17,6 +17,7 @@
 use Sulu\Bundle\ContentBundle\Content\Domain\Model\DimensionContentCollectionInterface;
 use Sulu\Bundle\ContentBundle\Content\Domain\Model\DimensionContentInterface;
 use Symfony\Component\PropertyAccess\PropertyAccessor;
+use Webmozart\Assert\Assert;
 
 class ContentMerger implements ContentMergerInterface
 {
@@ -41,6 +42,13 @@ public function __construct(
         $this->propertyAccessor = $propertyAccessor;
     }
 
+    /**
+     * @template T of DimensionContentInterface
+     *
+     * @param DimensionContentCollectionInterface<T> $dimensionContentCollection
+     *
+     * @return T
+     */
     public function merge(DimensionContentCollectionInterface $dimensionContentCollection): DimensionContentInterface
     {
         if (!$dimensionContentCollection->count()) {
@@ -52,6 +60,7 @@ public function merge(DimensionContentCollectionInterface $dimensionContentColle
         foreach ($dimensionContentCollection as $dimensionContent) {
             if (!$mergedDimensionContent) {
                 $contentRichEntity = $dimensionContent->getResource();
+                /** @var T $mergedDimensionContent */
                 $mergedDimensionContent = $contentRichEntity->createDimensionContent();
                 $mergedDimensionContent->markAsMerged();
             }
@@ -69,6 +78,8 @@ public function merge(DimensionContentCollectionInterface $dimensionContentColle
             }
         }
 
+        Assert::notNull($mergedDimensionContent);
+
         return $mergedDimensionContent;
     }
 }
diff --git a/Content/Domain/Model/TemplateInterface.php b/Content/Domain/Model/TemplateInterface.php
@@ -22,12 +22,12 @@ public function getTemplateKey(): ?string;
     public function setTemplateKey(string $templateKey): void;
 
     /**
-     * @return mixed[]
+     * @return array<string, mixed>
      */
     public function getTemplateData(): array;
 
     /**
-     * @param mixed[] $templateData
+     * @param array<string, mixed> $templateData
      */
     public function setTemplateData(array $templateData): void;
 }
diff --git a/Content/Domain/Model/TemplateTrait.php b/Content/Domain/Model/TemplateTrait.php
@@ -24,7 +24,7 @@ trait TemplateTrait
     private $templateKey;
 
     /**
-     * @var mixed[]
+     * @var array<string, mixed>
      */
     private $templateData = [];
 
@@ -43,6 +43,9 @@ public function getTemplateData(): array
         return $this->templateData;
     }
 
+    /**
+     * @param array<string, mixed> $templateData
+     */
     public function setTemplateData(array $templateData): void
     {
         $this->templateData = $templateData;

diff --git a/Content/Infrastructure/Sulu/Link/ContentLinkProvider.php b/Content/Infrastructure/Sulu/Link/ContentLinkProvider.php
@@ -108,7 +108,13 @@ public function preload(array $hrefs, $locale, $published = true): array
      */
     protected function getTitle(DimensionContentInterface $dimensionContent, array $data): ?string
     {
-        return $data['title'] ?? $data['name'] ?? null;
+        $title = $data['title'] ?? $data['name'] ?? null;
+
+        if (!\is_string($title)) {
+            return null;
+        }
+
+        return $title;
     }
 
     protected function getEntityIdField(): string

diff --git a/Content/Infrastructure/Sulu/Sitemap/ContentSitemapProvider.php b/Content/Infrastructure/Sulu/Sitemap/ContentSitemapProvider.php
@@ -163,7 +163,7 @@ public function getMaxPage($scheme, $host): int
     {
         $queryBuilder = $this->createRoutesQueryBuilder();
         try {
-            $amount = $queryBuilder
+            $amount = (int) $queryBuilder
                 ->select('COUNT(' . self::ROUTE_ALIAS . ')')
                 ->getQuery()
                 ->getSingleScalarResult();

diff --git a/Content/Infrastructure/Sulu/Teaser/ContentTeaserProvider.php b/Content/Infrastructure/Sulu/Teaser/ContentTeaserProvider.php
@@ -162,7 +162,7 @@ protected function createTeaser(DimensionContentInterface $dimensionContent, arr
 
     /**
      * @param B $dimensionContent
-     * @param mixed[] $data
+     * @param array<string, mixed> $data
      */
     protected function getTitle(DimensionContentInterface $dimensionContent, array $data): ?string
     {
@@ -172,7 +172,13 @@ protected function getTitle(DimensionContentInterface $dimensionContent, array $
             }
         }
 
-        return $data['title'] ?? $data['name'] ?? null;
+        $title = $data['title'] ?? $data['name'] ?? null;
+
+        if (!\is_string($title)) {
+            return null;
+        }
+
+        return $title;
     }
 
     /**

diff --git a/Tests/Application/ExampleTestBundle/Entity/ExampleDimensionContent.php b/Tests/Application/ExampleTestBundle/Entity/ExampleDimensionContent.php
@@ -85,10 +85,13 @@ public function getTitle(): ?string
         return $this->title;
     }
 
+    /**
+     * @param array<string, mixed> $templateData
+     */
     public function setTemplateData(array $templateData): void
     {
         if (\array_key_exists('title', $templateData)) {
-            $this->title = $templateData['title'];
+            $this->title = \is_string($templateData['title']) ? $templateData['title'] : null;
         }
 
         $this->parentSetTemplateData($templateData);

diff --git a/Tests/Functional/Content/Infrastructure/Sulu/Sitemap/ContentSitemapProviderTest.php b/Tests/Functional/Content/Infrastructure/Sulu/Sitemap/ContentSitemapProviderTest.php
@@ -167,7 +167,7 @@ public function testGetAlias(): void
     /**
      * @param SitemapUrl[] $sitemapEntries
      *
-     * @return array<string, mixed>
+     * @return array<mixed>
      */
     private function mapSitemapEntries(array $sitemapEntries): array
     {

diff --git a/Tests/Unit/Content/Application/ContentDataMapper/DataMapper/WebspaceDataMapperTest.php b/Tests/Unit/Content/Application/ContentDataMapper/DataMapper/WebspaceDataMapperTest.php
@@ -90,7 +90,7 @@ public function testMapDefaultWebspace(): void
 
         $webspace = new Webspace();
         $webspace->setKey('default-webspace');
-        $this->webspaceCollection->setWebspaces([$webspace]);
+        $this->webspaceCollection->setWebspaces(['default-webspace' => $webspace]);
 
         $authorMapper = $this->createWebspaceDataMapperInstance();
         $authorMapper->map($unlocalizedDimensionContent, $localizedDimensionContent, $data);

diff --git a/Tests/Unit/Content/Infrastructure/Sulu/Page/Select/WebspaceSelectTest.php b/Tests/Unit/Content/Infrastructure/Sulu/Page/Select/WebspaceSelectTest.php
@@ -49,8 +49,8 @@ public function testGetValues(): void
         $webspaceB->setKey('webspace-b');
         $webspaceB->setName('Webspace B');
         $webspaceCollection = new WebspaceCollection([
-            $webspaceA,
-            $webspaceB,
+            'webspace-a' => $webspaceA,
+            'webspace-b' => $webspaceB,
         ]);
 
         $this->webspaceManager->getWebspaceCollection()

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -1,22 +1,7 @@
 parameters:
 	ignoreErrors:
 		-
-			message: "#^Parameter \\#1 \\$array of function array_values expects array, array\\<string\\>\\|null given\\.$#"
+			message: "#^Parameter \\#1 \\$filters of method Sulu\\\\Component\\\\SmartContent\\\\Orm\\\\BaseDataProvider\\:\\:resolveDataItems\\(\\) expects array\\{dataSource\\?\\: int\\|string\\|null, sortMethod\\?\\: 'asc'\\|'desc', sortBy\\?\\: string, tags\\?\\: array\\<string\\>, tagOperator\\?\\: 'and'\\|'or', types\\?\\: array\\<string\\>, categories\\?\\: array\\<int\\>, categoryOperator\\?\\: 'and'\\|'or', \\.\\.\\.\\}, array given\\.$#"
 			count: 1
-			path: Tests/Application/ExampleTestBundle/Entity/ExampleDimensionContent.php
-
-		-
-			message: "#^Parameter \\#1 \\$array of function array_values expects array, array\\<string\\>\\|null given\\.$#"
-			count: 2
-			path: Tests/Unit/Content/Application/ContentNormalizer/ContentNormalizerTest.php
-
-		-
-			message: "#^Parameter \\#1 \\$array of function array_values expects array, array\\<string\\>\\|null given\\.$#"
-			count: 1
-			path: Tests/Unit/Content/Domain/Model/DimensionContentTraitTest.php
-
-		-
-			message: "#^Parameter \\#1 \\$array of function array_values expects array, array\\<string\\>\\|null given\\.$#"
-			count: 3
-			path: Tests/Unit/Content/Infrastructure/Sulu/Admin/ContentViewBuilderFactoryTest.php
+			path: Tests/Functional/Content/Infrastructure/Sulu/SmartContent/ContentDataProviderTest.php