Add priority to DataMapper, Merger and NormalizeEnhancer service definitions #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Resources/config/mapper.xml
Outdated
| @@ -8,18 +8,18 @@ | |||
| <argument type="service" id="sulu_page.structure.factory"/> | |||
| <argument>%sulu.content.structure.default_types%</argument> | |||
|
|
|||
| <tag name="sulu_content.data_mapper"/> | |||
| <tag name="sulu_content.data_mapper" priority="3072"/> | |||
There was a problem hiding this comment.
I don't understand the usage of this high numbers.
There was a problem hiding this comment.
i dont care about the specific numbers, just used the same pattern that sulu uses 🙂 what would you use?
There was a problem hiding this comment.
I think we should follow the rule what symfony does they have internal priorites only between -255 to 255.
Would go in this case with:
Template: 128
Workflow: 64
Excerpt: 32
Seo: 16
Routeable: -32
alexander-schranz
approved these changes
Mar 10, 2020
niklasnatter
force-pushed
the
enhancement/service-priorities
branch
from
1649d5f
to
93f2631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to influence the position of a custom
DataMapper/Merger/NormalizeEnhancer