New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AuthorInterface and dynamic settings form #193

Merged

alexander-schranz merged 11 commits into sulu:0.x from Prokyonn:feature/settings-tab

Jul 30, 2021

Member

Prokyonn commented Jul 29, 2021

Adds AuthorInterface
Adds functionality to dynamically extend the settings tab according to the Custom-Entity and the implemented interfaces


          Add AuthorInterface and dynamic settings form

36a2274

alexander-schranz reviewed

View reviewed changes

Content/Infrastructure/Sulu/Admin/ContentViewBuilderFactory.php Outdated Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

Content/Infrastructure/Sulu/Form/SettingsFormMetadataVisitor.php Outdated Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

Content/Infrastructure/Sulu/Form/SettingsFormMetadataVisitor.php Outdated Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

DependencyInjection/Compiler/SettingsFormPass.php Outdated Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

Resources/config/forms/content_settings_author.xml Outdated Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

Content/Application/ContentDataMapper/DataMapper/AuthorDataMapper.php Outdated Show resolved Hide resolved

Prokyonn force-pushed the feature/settings-tab branch from 8641683 to c6654d6 Compare

July 29, 2021 14:34


          Add review suggestions

49c3604

Prokyonn force-pushed the feature/settings-tab branch from c6654d6 to 49c3604 Compare

July 29, 2021 14:35


          Fix old tests

01da991

coveralls commented Jul 29, 2021 •

edited

Loading

Pull Request Test Coverage Report for Build 1082125946

135 of 135 (100.0%) changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 963428561:	0.0%
Covered Lines:	1907
Relevant Lines:	1907

💛 - Coveralls


          Add tests

29bf9d0

Prokyonn force-pushed the feature/settings-tab branch from f36e65d to 29bf9d0 Compare

July 29, 2021 22:43

Prokyonn added 3 commits

July 30, 2021 09:45


          Add missing tests

57639c0


          Fix compiler pass test

8f4e0c7


          Increase sulu requirement to > 2.3

5c36019

Prokyonn marked this pull request as ready for review

July 30, 2021 08:38

Prokyonn assigned alexander-schranz

alexander-schranz reviewed

View reviewed changes

Content/Domain/Model/AuthorTrait.php Outdated Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

Content/Infrastructure/Sulu/Form/SettingsFormMetadataVisitor.php Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

Resources/config/forms/content_settings_author.xml Outdated Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

Tests/Functional/Integration/responses/example_get.json Outdated Show resolved Hide resolved

alexander-schranz requested changes

View reviewed changes

Tests/Functional/Integration/responses/example_post.json Outdated Show resolved Hide resolved

Tests/Functional/Integration/responses/example_post_publish.json Outdated Show resolved Hide resolved

Tests/Functional/Integration/responses/example_post_trigger_unpublish.json Outdated Show resolved Hide resolved

Tests/Functional/Integration/responses/example_put.json Outdated Show resolved Hide resolved

Resources/config/forms/content_settings_author.xml Outdated Show resolved Hide resolved

DependencyInjection/Compiler/SettingsFormPass.php Outdated Show resolved Hide resolved

DependencyInjection/Compiler/SettingsFormPass.php Outdated Show resolved Hide resolved

DependencyInjection/Compiler/SettingsFormPass.php Outdated Show resolved Hide resolved

alexander-schranz reviewed

View reviewed changes

composer.json Outdated Show resolved Hide resolved

Prokyonn and others added 3 commits

July 30, 2021 11:15


          Apply suggestions from code review

b10440b

Co-authored-by: Alexander Schranz <alexander@sulu.io>


          Add review suggestions

b9b0b95


          Add pass test for coverage

4c7c1d8

alexander-schranz reviewed

View reviewed changes

DependencyInjection/Compiler/SettingsFormPass.php Outdated Show resolved Hide resolved


          Update DependencyInjection/Compiler/SettingsFormPass.php

7a1cd93

alexander-schranz approved these changes

View reviewed changes

alexander-schranz enabled auto-merge (squash)

July 30, 2021 12:04

alexander-schranz merged commit d6b82d2 into sulu:0.x

alexander-schranz mentioned this pull request

Add experimental ArticleRepository and ArticleController sulu/SuluArticleBundle#583

Draft

45 tasks

alexander-schranz mentioned this pull request

Created, Changed, Creator and Changer not available in Structure #225

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment