Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usage of tag 'sulu.rlp' to detect route property #201

Closed
wants to merge 1 commit into from
Closed

Add usage of tag 'sulu.rlp' to detect route property #201

wants to merge 1 commit into from

Conversation

wachterjohannes
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1290960441

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1234014758: 0.0%
Covered Lines: 1917
Relevant Lines: 1917
💛 - Coveralls

@alexander-schranz
Copy link
Member

The sulu.rlp tag is deprecated and should should not longer be used for this kind of things. Route attribute should only be loaded by the route types route, resourceLocator, ... not by a tag.

@wachterjohannes wachterjohannes deleted the route-mappper-tag branch October 1, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasnatter niklasnatter Awaiting requested review from niklasnatter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachterjohannes @coveralls @alexander-schranz