Fix object provider and route defaults provider without id #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
the
Bug
alexander-schranz
force-pushed
the
bugfix/entity-object-provider-without-id
branch
from
d3d3ae2
to
c880eac
Compare
alexander-schranz
changed the title
Pull Request Test Coverage Report for Build 1340854061
💛 - Coveralls |
wachterjohannes
requested changes
Oct 14, 2021
There was a problem hiding this comment.
@alexander-schranz makes sense but seems that it does not work 🙈
wachterjohannes
approved these changes
Oct 14, 2021
alexander-schranz
deleted the
bugfix/entity-object-provider-without-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an entity has not an id instead of uuid as identifier the query in content object provider should not fail. In future the entity for
smart_content,preview,route default providerandworkflowshould be provided over aContentObjectProviderand not by a query build inside the content bundle.