Add Webspace select to Settings Tab #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/webspace-setting
branch
2 times, most recently
from
563107e
to
cf98c55
Compare
alexander-schranz
force-pushed
the
feature/webspace-setting
branch
from
cf98c55
to
53649e5
Compare
Pull Request Test Coverage Report for Build 1343198460
💛 - Coveralls |
alexander-schranz
force-pushed
the
feature/webspace-setting
branch
9 times, most recently
from
fe3480c
to
874aa9b
Compare
alexander-schranz
force-pushed
the
feature/webspace-setting
branch
from
874aa9b
to
ecfab9d
Compare
wachterjohannes
requested changes
Oct 15, 2021
| @@ -23,6 +23,12 @@ | |||
| </service> | |||
|
|
|||
| <service id="sulu_content.workflow_data_mapper" class="Sulu\Bundle\ContentBundle\Content\Application\ContentDataMapper\DataMapper\WorkflowDataMapper"> | |||
| <tag name="sulu_content.data_mapper" priority="24"/> | |||
There was a problem hiding this comment.
why 24? seems a strange number 🙈
There was a problem hiding this comment.
@wachterjohannes Which steps between the mergers would you use?
There was a problem hiding this comment.
its ok 😂 thought it is a strange number - maybe add a comment that it has to be between
| @@ -17,6 +17,10 @@ | |||
| </service> | |||
|
|
|||
| <service id="sulu_content.seo_merger" class="Sulu\Bundle\ContentBundle\Content\Application\ContentMerger\Merger\SeoMerger"> | |||
| <tag name="sulu_content.merger" priority="24"/> | |||
There was a problem hiding this comment.
is between the other mergers
45 tasks
wachterjohannes
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most entities like
Articleand any routable Custom Entity will have a webspace selection in its settings tab. I did go here with the nameWebspaceInterface.The entity like
Pagewill not implement it as the webspace will there not be on the PageDimensionContent Entity and so not implement for its webspace a content interface. Other entity like snippet which will have content will not have a Webspace field or relation.TODO