Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix availableLocales after unpublish #216

Merged

Conversation

alexander-schranz
Copy link
Member

The availableLocacles should represent the locales which currently are available at this stage. When unpublish the locale need to be removed from it.

@@ -0,0 +1,22 @@
parameters:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update phpstan in another issue as this seems to work in phpstan 1.0

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label Jan 25, 2022
Copy link
Member

@wachterjohannes wachterjohannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting is failing

@wachterjohannes wachterjohannes enabled auto-merge (squash) January 25, 2022 12:40
@wachterjohannes wachterjohannes merged commit 69afdaa into sulu:0.x Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants