Add support for symfony 6 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3176702716
💛 - Coveralls |
|
@mario-fehr the return types in the public function registerBundles(): iterablepublic function registerContainerConfiguration(LoaderInterface $loader): voidprotected function getKernelParameters(): array |
mario-fehr
force-pushed
the
enhancement/symfony-6-support
branch
from
7850098
to
99e536a
Compare
mario-fehr
commented
Aug 10, 2022
| @@ -109,7 +108,6 @@ | |||
| "check-coverage": [ | |||
| "@php vendor/bin/code-coverage-checker \"Tests/reports/coverage.php\" \"line\" \"100.00\" \"Content\" \"DependencyInjection\"" | |||
| ], | |||
| "deptract": "vendor/bin/deptrac", | |||
There was a problem hiding this comment.
A deptract command already exists in composer file.
mario-fehr
commented
Aug 10, 2022
Content/Infrastructure/Sulu/Search/ContentSearchMetadataProvider.php
Outdated
Show resolved
Hide resolved
mario-fehr
commented
Aug 10, 2022
Tests/Unit/Content/Application/ContentWorkflow/ContentWorkflowTest.php
Outdated
Show resolved
Hide resolved
|
@alexander-schranz as discussed in slack upgrade of phpstan packages and linting fixes will be done in an upcoming PR. |
alexander-schranz
force-pushed
the
enhancement/symfony-6-support
branch
from
4223843
to
00ca814
Compare
alexander-schranz
force-pushed
the
enhancement/symfony-6-support
branch
from
00ca814
to
938f483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR updates the bundle to be compatible with Symfony 6.