Add indexes to improve performance of some queries #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/query-performance
branch
from
9fd9a4a
to
639c29c
Compare
| @@ -460,7 +459,6 @@ protected function createEntityIdsQueryBuilder(string $locale): QueryBuilder | |||
|
|
|||
| return $this->entityManager->createQueryBuilder() | |||
| ->select(self::CONTENT_RICH_ENTITY_ALIAS . '.' . $this->getEntityIdentifierFieldName() . ' as id') | |||
| ->distinct() | |||
There was a problem hiding this comment.
This hurts the performance a lot but is not necessary. All joins of filters should be created the way that no distinct is required here else we will run into a lot of performance issues.
There was a problem hiding this comment.
We should in future have a look at the queries that we not longer have todo distinct as it seems have bad effects on this kind of queries. See #227
| @@ -402,6 +401,8 @@ protected function setSortByJoins(QueryBuilder $queryBuilder): array | |||
| */ | |||
| protected function appendRelation(QueryBuilder $queryBuilder, string $relation, array $values, string $operator, string $alias): array | |||
| { | |||
| $queryBuilder->distinct(); // TODO remove distinct and replace joins with subselect filter see: https://github.com/sulu/SuluContentBundle/pull/226 | |||
There was a problem hiding this comment.
created an issue for this. here some improvements could be made: #227
alexander-schranz
force-pushed
the
feature/query-performance
branch
from
a529d42
to
d0eefbd
Compare
Pull Request Test Coverage Report for Build 3177569846
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While having a look at our projects recipe bundle. I got hit by very slow queries.
Before: ~2023 ms
After: ~20ms (without filters, with tag or category filters ~1300ms see #227 for more improvements)