Add Shadow Locale to Settings Tab #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
feature/shadow-locale
branch
3 times, most recently
from
e2c6502
to
44e8188
Compare
Pull Request Test Coverage Report for Build 4498473987
💛 - Coveralls |
alexander-schranz
force-pushed
the
feature/shadow-locale
branch
7 times, most recently
from
d2309a3
to
3b1e113
Compare
alexander-schranz
force-pushed
the
feature/shadow-locale
branch
from
3b1e113
to
750fc9d
Compare
alexander-schranz
changed the title
Prokyonn
reviewed
Mar 22, 2023
|
|
||
| $normalizedData['shadowOn'] = null !== $object->getShadowLocale(); | ||
| $normalizedData['shadowLocales'] = $normalizedData['shadowLocales'] ?? []; | ||
| $normalizedData['contentLocales'] = $object->getAvailableLocales() ?? []; // TODO should be changed in Sulu Core (PageSettingsShadowLocaleSelect.js) |
There was a problem hiding this comment.
Issue: sulu/sulu#7040
Prokyonn
reviewed
Mar 23, 2023
Co-authored-by: Prokyonn <daniel.mathis@sector8.eu>
Prokyonn
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide a shadow locale feature we add a new ShadowInterface for this which provides this feature. Then new
shadowLocaleandshadowLocalesfeature is added to the DimensionContent entities and added to the Settings tab.In upcoming Pull Request the shadow behaviour while publishing should be implemented and checked how we handle the
urlhere.