-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add routable-interface and the handling of routes in the template data #43
Merged
alexander-schranz
merged 3 commits into
sulu:master
from
wachterjohannes:feature/routable
Nov 19, 2019
Merged
Add routable-interface and the handling of routes in the template data #43
alexander-schranz
merged 3 commits into
sulu:master
from
wachterjohannes:feature/routable
Nov 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c7b9df
to
f7ac84f
Compare
262644e
to
a3e40a1
Compare
ac59461
to
effa69c
Compare
alexander-schranz
requested changes
Nov 18, 2019
Content/Application/ContentDimensionFactory/Mapper/RouteMapper.php
Outdated
Show resolved
Hide resolved
Content/Application/ContentDimensionFactory/Mapper/RouteMapper.php
Outdated
Show resolved
Hide resolved
3a3f14a
to
613097f
Compare
c56e5e6
to
5341168
Compare
5341168
to
801357d
Compare
Tests/Application/ExampleTestBundle/Resources/views/examples/default.html.twig
Outdated
Show resolved
Hide resolved
801357d
to
48be192
Compare
@alexander-schranz done |
48be192
to
f82c288
Compare
alexander-schranz
approved these changes
Nov 19, 2019
a9530cd
to
a723452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Technical Debt
Impacts only code quality, no or just small impact on end developers and users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #41
Requires: Related PR sulu/sulu#4890 (merged) and sulu/sulu#4892 (merged)