Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare entity-independent methods on marker interfaces as static #99

Closed
wants to merge 1 commit into from
Closed

Declare entity-independent methods on marker interfaces as static #99

wants to merge 1 commit into from

Conversation

niklasnatter
Copy link
Contributor

@niklasnatter niklasnatter commented Mar 3, 2020 •
edited by alexander-schranz
Loading

  • RoutableInterface:: getContentClass
  • TemplateInterface:: getTemplateType
  • WorkflowInterface:: getWorkflowName

@alexander-schranz
Copy link
Member

Making it static will break exist projects code. Should we create a tag maybe before and then provide a UPGRADE path?

@alexander-schranz alexander-schranz added the DX Only affecting the end developer label Mar 3, 2020
@alexander-schranz
Copy link
Member

alexander-schranz commented Mar 3, 2020 •
edited
Loading

The tests are failing because prophecy can not mock static methods as I know.

@niklasnatter niklasnatter force-pushed the enhancement/static-methods branch 3 times, most recently from 0c1c42b to 811560c Compare March 3, 2020 16:22
@niklasnatter
Copy link
Contributor Author

mocking of static methods is really a pain 🤔 need to think about this..

This was referenced Mar 9, 2020
Merged
Closed
Merged
@niklasnatter
Copy link
Contributor Author

Replaced by #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DX Only affecting the end developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niklasnatter @alexander-schranz